Repository navigation
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a comprehensive guide and reproducible examples for running NVIDIA OpenShell sandboxes and Agent Substrate actors on a single Agent Mesh, including a new Kubernetes-based OpenShell example and updates to existing examples to support remote hubs and version pinning. The review feedback identifies a security issue in both the openshell-kubernetes and substrate-actor Makefiles, where sensitive tokens are generated with insecure file permissions (umask 022). It is recommended to restrict these permissions using umask 077 to ensure the tokens are readable only by the owner.
aojea
force-pushed
the
ntk-openshell-to-substrate
branch
from
October 18, 2026 13:43
188ee3f to
78b3725
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closed; superseded by a later pull request.