Repository navigation
docs: name the router's control plane sync flag under --key-grace-period - #748
Merged
aojea merged 1 commit intoOct 18, 2026
Merged
Conversation
The control plane reference tells operators to keep the router's key pull well within --key-grace-period with agentmesh-router --keys-sync-interval. That flag went with the single control plane sync loop (b9719e0); the router now pulls /keys every --control-plane-sync-interval, and refuses the old flag as unknown.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the documentation in site/content/docs/reference/control-plane.md to correct the flag name for agentmesh-router from --keys-sync-interval to --control-plane-sync-interval in the description of the --key-grace-period option. There are no review comments, and I have no additional feedback to provide.
Collaborator
|
upps, thanks for catching it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The
--key-grace-periodrow of the control plane reference says nodes and routers must pull/keyswell within the grace period, and names the flags that set it:--keys-sync-intervalwent with the single control plane sync loop (b9719e0, #719). The router now pulls/keysevery--control-plane-sync-interval, and its help text already asks for that interval to stay "well below the control plane's --lease-duration and --key-grace-period". A router started with the documented flag does not start:Fix
The row names
agentmesh-router --control-plane-sync-interval, assite/content/docs/reference/router.mddoes. No other reference to the removed flag is left in the repository.Docs only; checked against a router built from main at 70fbb22.