Fix default workload for datasets with fewer than three columns - #196
Open
ArijanaBohr wants to merge 1 commit into
Open
ArijanaBohr wants to merge 1 commit into
ArijanaBohr wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
👋 Welcome, and thanks for opening your first PR!
We're excited to have you contribute. A few things to help you get started:
- Join the community! Say hello on the Google Differential Privacy Slack — we'd love to hear who you are, what you're working on, and what brought you here.
- A maintainer will review your PR shortly. If you have questions in the meantime, don't hesitate to ask here or on Slack.
Thanks for contributing to privacy-preserving synthetic data generation! 🔐
ArijanaBohr
force-pushed
the
fix-default-workload-two-columns
branch
from
September 22, 2026 19:20
ce92379 to
81f2ff7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default workload in
supporting_cliquesandcompiled_workloaduses all three-way marginals. For datasets with fewer than three columns, this produces an empty workload and can cause mechanisms such as AIM and SWIFT to fail.Datasets with fewer than three columns, however, are already supported elsewhere (e.g., MST), and
compiled_workloadis tested with a two-column domain when an explicit workload is provided. This leaves the default workload (workload=None) as the remaining edge case for datasets with fewer than three columns.This PR sets the default workload degree to
min(3, len(domain.attributes)), preserving the existing behavior for datasets with three or more columns while using the maximum possible degree for datasets with fewer columns. Thesupporting_cliquesdocstring is updated accordingly.Testing