Repository navigation
Conversation
DynamicIntegerPointsKdTreeEncoder allocates memory quadratic in the point dimension, up front, in its constructor: a base and a levels vector for each of the 32 * dimension levels the tree can reach. The dimension is the total number of components over all attributes. This change makes the encoder's memory linear in the dimension, the way DynamicIntegerPointsKdTreeDecoder already works. The encoded bytes are unchanged. A split changes one base value and one level. The encoder now keeps a single base and levels vector, records the old values at each split, and restores them when the walk returns to a shallower node. TestKdTreeEncodingOfManyComponents round-trips three equal points with 25 attributes of 255 components. The walk goes 11 * 6375 levels deep, far past what the existing tests reach, which is where the restore does its work.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DynamicIntegerPointsKdTreeEncoder allocates memory quadratic in the point dimension, up front, in its constructor. The dimension is the total number of components over all attributes. This change makes the encoder's memory linear in the dimension, the way DynamicIntegerPointsKdTreeDecoder already works since #1241. The encoded bytes are unchanged.
Encoder memory by dimension:
What this means in practice:
How: the encoder kept a full copy of the node's base and levels for every level of the tree, which is 32 × dimension levels deep. A split changes only one base value and one level. The encoder now keeps a single base and levels vector, records the old values at each split, and restores them when the walk returns to a shallower node. This is the same walk the decoder uses.
Verification: