Validate dropout_rate in dot_product_attention#5503
Open
mohsinm-dev wants to merge 2 commits into
Open
Conversation
vfdev-5
reviewed
Jun 17, 2026
| np.testing.assert_allclose(nnx_out, jax_out, atol=1e-3, rtol=1e-3) | ||
|
|
||
|
|
||
| class TestDropoutRateValidation(parameterized.TestCase): |
Collaborator
There was a problem hiding this comment.
Reduce the number of tests to essential only and use parameterize as much as you can to reduce the number of lines
mohsinm-dev
force-pushed
the
validate-dropout-rate
branch
from
66934c0 to
89b5e6b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5497
Reject
dropout_rateoutside[0, 1)(including NaN/inf) with a clearValueError, and raise early whendropout_rngis missing for active dropout.