fix: treat BusinessTeam as a regular Team for Environment reviewers - #4456
Open
JWilkinsonMB wants to merge 1 commit into
Open
fix: treat BusinessTeam as a regular Team for Environment reviewers#4456JWilkinsonMB wants to merge 1 commit into
JWilkinsonMB wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is now supported to use Enterprise Teams as reviewers for Environments, however the type returned by the API has changed, so that instead of Team, it is now BusinessTeam. Sample JSON below:
{ "reviewers": [ { "type": "BusinessTeam", "reviewer": { "name": "Name", "id": 123456, "node_id": "ET_xyz123456", "slug": "ent:xyz123", "description": "", "privacy": "closed", "notification_setting": "notifications_enabled", "url": "https://api.github.com/enterprises/xyz/teams/123456", "html_url": "https://github.com/enterprises/xyz/teams/ent:desktop", "members_url": "https://api.github.com/enterprises/xyz/teams/123456/memberships{/member}", "repositories_url": "https://api.github.com/enterprises/xyz/teams/123456/repos", "type": "enterprise", "enterprise_id": 123, "permission": "pull", "parent": null } } ] }Prior to this PR this leads to an unmarshaling error if an enterprise team is included as a reviewer in any environment that the library tries to read.
Whilst there are some differences between a BusinessTeam and a Team such as enterprise_id instead of organization_id, a quick workaround is to treat both types as a Team given there is sufficient overlap which allows consumers such as the Terraform provider to be able to work without any breaking changes.
Fixes #4457