Display language names in own language#3729
Open
andreia-ferreira wants to merge 7 commits into
Open
Conversation
andreia-ferreira
temporarily deployed
to
e2e-approval
GitHub Actions
Inactive
andreia-ferreira
temporarily deployed
to
e2e-approval
GitHub Actions
Inactive
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3729 +/- ##
============================================
- Coverage 68.06% 68.02% -0.05%
+ Complexity 1609 1608 -1
============================================
Files 370 370
Lines 9513 9550 +37
Branches 1238 1240 +2
============================================
+ Hits 6475 6496 +21
- Misses 2360 2377 +17
+ Partials 678 677 -1
🚀 New features to boost your workflow:
|
| internal fun SettingsItem(title: String, summary: String? = null, onClick: () -> Unit) { | ||
| internal fun SettingsItem( | ||
| modifier: Modifier = Modifier, | ||
| @DrawableRes trailingIcon: Int, |
Member
There was a problem hiding this comment.
nit: Consider renaming this parameter for clarity as the position is not at the end.
Collaborator
Author
There was a problem hiding this comment.
good catch, renamed it 👍
Comment on lines
+65
to
+66
| Modifier.padding(end = MaterialTheme.sizes.settingsTrailingIconEndPadding) | ||
| .size(MaterialTheme.sizes.settingsTrailingIconSize), |
Member
There was a problem hiding this comment.
Same as previous comment, consider renaming the dimensions.
| contentDescription = null, | ||
| tint = MaterialTheme.colorScheme.onSurfaceVariant, | ||
| ) | ||
| Column { |
Member
There was a problem hiding this comment.
nit: We dropped Modifier.weight(1f) from column. Is this intentional?
Collaborator
Author
There was a problem hiding this comment.
it was removed by mistake, added it again, thanks
andreia-ferreira
temporarily deployed
to
e2e-approval
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3379
Moved the languages to the untranslated strings, in order to display their names in their native language. Also updated the settings page to show icons for each setting in order to improve discoverability.
@shobhitagarwal1612 PTAL?