syscall: Return E2BIG for oversized exec args and open first - #15007
Open
copybara-service[bot] wants to merge 1 commit into
Open
copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
copybara-service
Bot
force-pushed
the
test/cl988510855
branch
5 times, most recently
from
October 1, 2026 04:08
ca91fbe to
6fa705d
Compare
CopyInVector reports oversized argv/envv as ENAMETOOLONG or ENOMEM. Linux copy_strings returns E2BIG. This showed up in datalad's test_too_long: a valid python path plus CMD_MAX_ARG arguments produced "File name too long" instead of "argument list too long": https://github.com/datalad/datalad/blob/256c5946ac3c920748ed7de6366b90be26cdedad/datalad/runner/tests/test_witless_runner.py#L338 Linux also opens the file first (fs/exec.c:alloc_bprm), so pathname errors beat E2BIG. Open in execveat before copying argv/envv. FUTURE_COPYBARA_INTEGRATE_REVIEW=#14853 from tanyifeng:fix-execve-e2big bd27899 PiperOrigin-RevId: 988510855
copybara-service
Bot
force-pushed
the
test/cl988510855
branch
from
October 1, 2026 05:27
6fa705d to
e7f5d35
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
syscall: Return E2BIG for oversized exec args and open first
CopyInVector reports oversized argv/envv as ENAMETOOLONG or ENOMEM. Linux copy_strings returns E2BIG.
This showed up in datalad's test_too_long: a valid python path plus CMD_MAX_ARG arguments produced "File name too long" instead of "argument list too long":
https://github.com/datalad/datalad/blob/256c5946ac3c920748ed7de6366b90be26cdedad/datalad/runner/tests/test_witless_runner.py#L338
Linux also opens the file first (fs/exec.c:alloc_bprm), so pathname errors beat E2BIG. Open in execveat before copying argv/envv.
FUTURE_COPYBARA_INTEGRATE_REVIEW=#14853 from tanyifeng:fix-execve-e2big bd27899