Reset Go build modes for the Nogo tool - #15104
Merged
Merged
Conversation
copybara-service
Bot
force-pushed
the
test/cl990407447
branch
2 times, most recently
from
October 1, 2026 05:41
4d32f37 to
4628b6f
Compare
Nogo's exec dependencies select the execution platform but retain the Go build modes of the package being analyzed. A static target can therefore make the analyzer link statically against the execution toolchain. This fails with the hermetic GNU toolchain, which provides shared glibc linking stubs rather than static archives [1]. Route all four Nogo tool dependencies through rules_go's go_reset_target [2], retaining their exec transitions for platform selection. This resets Go build modes before configuring the analyzer, independently of the package's static, race, or other mode settings. Keep the existing nogo binary and its analysis target available for direct use. [1]: https://app.buildbuddy.io/invocation/00d0c051-3fef-4fcb-b279-b158879c216e [2]: https://github.com/bazel-contrib/rules_go/blob/v0.57.0/go/private/rules/transition.bzl#L312-L339 Assisted-by: Codex COPYBARA_INTEGRATE_REVIEW=#15048 from tamird:nogo-reset-exec-mode dca9ff6 PiperOrigin-RevId: 991461175
copybara-service
Bot
force-pushed
the
test/cl990407447
branch
from
October 1, 2026 06:46
4628b6f to
71a606a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reset Go build modes for the Nogo tool
Nogo's exec dependencies select the execution platform but retain the Go build modes of the package being analyzed. A static target can therefore make the analyzer link statically against the execution toolchain. This fails with the hermetic GNU toolchain, which provides shared glibc linking stubs rather than static archives 1.
Route all four Nogo tool dependencies through rules_go's go_reset_target 2, retaining their exec transitions for platform selection. This resets Go build modes before configuring the analyzer, independently of the package's static, race, or other mode settings. Keep the existing nogo binary and its analysis target available for direct use.
Assisted-by: Codex
FUTURE_COPYBARA_INTEGRATE_REVIEW=#15048 from tamird:nogo-reset-exec-mode dca9ff6