Preserve fio output when a benchmark fails - #15174
Open
copybara-service[bot] wants to merge 1 commit into
Open
copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
Docker exec returns fio's output together with a nonzero exit status, but the benchmark discards it on failure. This leaves the status without the diagnostic explaining which I/O operation failed. Include the captured output in the benchmark failure, as the surrounding setup commands already do. Keep the failure status and workload intact. Assisted-by: Codex <!-- codex-thread: 01a0680f-bbf5-7511-95f7-4414f4e10d2e --> FUTURE_COPYBARA_INTEGRATE_REVIEW=#15140 from tamird:benchmark-fio-error-output 4c38639 PiperOrigin-RevId: 991365396
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserve fio output when a benchmark fails
Docker exec returns fio's output together with a nonzero exit status, but the benchmark discards it on failure. This leaves the status without the diagnostic explaining which I/O operation failed.
Include the captured output in the benchmark failure, as the surrounding setup commands already do. Keep the failure status and workload intact.
Assisted-by: Codex
FUTURE_COPYBARA_INTEGRATE_REVIEW=#15140 from tamird:benchmark-fio-error-output 4c38639