Skip to content

reskin flip camera button - #544

Open
Kimblebee wants to merge 5 commits into
temcguir/extract_overlap_detectionfrom
kim/reskin/flip_camera_button
Open

reskin flip camera button#544
Kimblebee wants to merge 5 commits into
temcguir/extract_overlap_detectionfrom
kim/reskin/flip_camera_button

Conversation

@Kimblebee

@Kimblebee Kimblebee commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

update the flip camera button to match design specs.
Screenshot 2026-08-12 at 10 30 18 AM

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the FlipCameraButton to use FilledIconButton with custom styling and adds a Compose preview for it. Feedback on these changes includes reverting an unrelated bump of minSdk in libs.versions.toml, removing an unused IconButton import, and improving the button's visibility on bright viewfinders by using a semi-transparent dark container color instead of a white one.

Comment thread gradle/libs.versions.toml
@Kimblebee
Kimblebee force-pushed the kim/reskin/flip_camera_button branch from f4b246c to 04fa0bf Compare July 30, 2026 20:24
- Move single-lens check from UI to FlipLensUiStateAdapter.
- Fix visibility of FlipCameraButton in previews by providing correct background style.
- Fix E2E test regressions caused by hiding FlipCameraButton on single-lens devices.
@Kimblebee
Kimblebee force-pushed the kim/reskin/flip_camera_button branch from d418883 to a3c1635 Compare August 12, 2026 17:31
@Kimblebee
Kimblebee changed the base branch from main to temcguir/extract_overlap_detection August 12, 2026 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants