Refactor: Move Hilt modules from core to data layer (Reattempt) - #556
Open
davidjiagoogle wants to merge 6 commits into
Open
Refactor: Move Hilt modules from core to data layer (Reattempt)#556davidjiagoogle wants to merge 6 commits into
davidjiagoogle wants to merge 6 commits into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the dependency injection (DI) structure of the Jetpack Camera App by introducing dedicated DI submodules (such as low-light-di and postprocess-di) and moving qualifiers and modules to a centralized di package. The feedback suggests optimizing Dagger modules by converting CommonModule to an object and abstract modules to interfaces. Additionally, it recommends restoring the @DefaultSaveMode qualifier for consistency and removing the redundant repositoryScope in LocalMediaRepository to avoid coroutine anti-patterns.
temcguir
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-applies commit 57371e0 (PR #537) which was reverted in bbe6153.