Skip to content

Refactor: Move Hilt modules from core to data layer (Reattempt) - #556

Open
davidjiagoogle wants to merge 6 commits into
mainfrom
david/hiltRemovelReattempt
Open

Refactor: Move Hilt modules from core to data layer (Reattempt)#556
davidjiagoogle wants to merge 6 commits into
mainfrom
david/hiltRemovelReattempt

Conversation

@davidjiagoogle

Copy link
Copy Markdown
Collaborator

Re-applies commit 57371e0 (PR #537) which was reverted in bbe6153.

  • Created :core📷low-light-playservices-di, :core📷low-light:low-light-di, and :core📷postprocess:postprocess-di modules.
  • Moved Hilt @module classes into separate DI modules or app module.
  • Cleaned unused dependencies from capability modules.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the dependency injection (DI) structure of the Jetpack Camera App by introducing dedicated DI submodules (such as low-light-di and postprocess-di) and moving qualifiers and modules to a centralized di package. The feedback suggests optimizing Dagger modules by converting CommonModule to an object and abstract modules to interfaces. Additionally, it recommends restoring the @DefaultSaveMode qualifier for consistency and removing the redundant repositoryScope in LocalMediaRepository to avoid coroutine anti-patterns.

Comment thread app/src/main/java/com/google/jetpackcamera/di/CommonModule.kt Outdated
Comment thread app/src/main/java/com/google/jetpackcamera/di/AppQualifiers.kt Outdated
Comment thread app/src/main/java/com/google/jetpackcamera/AppModule.kt
@davidjiagoogle
davidjiagoogle requested a review from temcguir August 5, 2026 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants