Skip to content

Avoid quadratic block comment indent allocation #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SantanDon wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Avoid quadratic block comment indent allocation #47

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions src/parser.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -425,10 +425,18 @@ impl<'parser> Parser<'parser> {
// the block comment, and 2 spaces on subsequent lines, assuming the line content is
// meant to be vertically aligned.
let indent_count = self.column_number - 3;
let indent = " ".repeat(indent_count);
if content.lines().enumerate().any(|(index, line)| {
index > 0 && !line.starts_with(&indent) && line.trim() != ""
}) {
// Check the prefix in place instead of allocating an indent-sized String for every
// block comment. Repeated comments at large columns can otherwise become quadratic.
let has_indent = |line: &str| {
line.as_bytes()
.get(..indent_count)
.map_or(false, |prefix| prefix.iter().all(|&byte| byte == b' '))
};
if content
.lines()
.enumerate()
.any(|(index, line)| index > 0 && !has_indent(line) && line.trim() != "")
{
self.with_container(|container| {
container.add_block_comment(Comment::Block {
lines: content.lines().map(|line| line.to_owned()).collect(),
Expand Down