Add KSVisitorNext - #3059
Merged
Merged
Conversation
jaschdoc
force-pushed
the
ksvisitornext
branch
2 times, most recently
from
July 21, 2026 09:57
427d38d to
45d061b
Compare
KSVisitorNext is a subtype of KSVisitor and has the additional visitBackingField function. All existing visitors implement the KSVisitorNext interface instead. Doing so maintains binary compatibility because there is no requirement to use KSVisitorNext. If a processor library has its own implementation of a KSVisitor, it will still work.
troelsbjerre
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the
KSVisitorNext<D, R> : KSVisitor<D, R>interface that decorates theKSVisitorinterface with avisitBackingFieldfunction. All existing implementations ofKSVisitormove toKSVisitorNext. TheKSVisitorinterface is then deprecated to inform processor authors that they should move toKSVisitorNext. The deprecation is informative and actionable. Also, it uses theReplaceWithannotation to allow IDEs to easily suggest a fix.Depends on #3058
Supersedes #2969
Related to #2873