fix: expose raw typed annotation lookup - #3092
Open
mvanhorn wants to merge 1 commit into
Open
Conversation
Collaborator
|
Hi @mvanhorn, thanks for the PR! Could you add a test for this first in a separate PR? See https://github.com/google/ksp/blob/main/CONTRIBUTING.md for more information :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an experimental
getKSAnnotationsByType()utility that reuses the existing short-name and qualified-name matching logic while returningSequence<KSAnnotation>without constructing annotation proxies.KSAnnotated.getAnnotationsByType()still converts every matchingKSAnnotationinto a runtime annotation proxy.A source annotation with one
KClassmember and an array ofKClassmembers is found throughgetKSAnnotationsByType(), and the processor reads the expected qualified names from the rawKSTypeargument values without throwing; Built-in, source-declared, array, and generic array class literals remain distinguishable through the raw values, while the existing typed lookup continues to match the same annotation and retain its established proxy behavior.Fixes #1038