Add support for an env_str in mobly#1004
Open
hongyu-wang wants to merge 2 commits intogoogle:masterfrom
Open
Conversation
mhaoli
reviewed
May 6, 2026
| am_instrument_options: Dict[str, str] = dataclasses.field( | ||
| default_factory=dict | ||
| ) | ||
| env: str = '' |
Collaborator
There was a problem hiding this comment.
Please place the new arg env after the existing arg user_id to avoid breaking existing users.
| other purposes may not take effect and you should use snippet RPCs. This | ||
| is because Mobly snippet runner changes the subsequent instrumentation | ||
| process. | ||
| env: A string of prefix options (e.g., environment variables or command |
Collaborator
There was a problem hiding this comment.
Please also adjust the position of env in docstring.
Collaborator
|
Please fix the format issue by following this doc: https://github.com/google/mobly/blob/master/CONTRIBUTING.md#code-style |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This CL adds an env field to snippet_client_v2.Config, allowing users to prepend environment variables or command wrappers to the am instrument command used to start snippet servers.