fix: use dedicated buildx builder instance in cloud build - #5881
Merged
Conversation
cuixq
marked this pull request as ready for review
August 21, 2026 03:29
michaelkedar
approved these changes
Aug 21, 2026
cuixq
added a commit
that referenced
this pull request
Aug 21, 2026
Hope this is the last try for #5692... In #5877, `recoverer` was migrated to Go and added as a `buildx build` step in `deployment/build-and-stage.yaml`. However, it was missing `--load` and the shared `docker-config` volume introduced in #5881. As a result, the built image was retained inside the `osv-builder` container and never loaded into the host Docker daemon's image store.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second try for #5692
Cloud Build steps building Go images (such as
build-importer) have been intermittently failing with the following error:#5874 tried to fix the issue by pinning
# syntax=docker/dockerfile:1.4:1.4) that introduced--build-context, the fundamental mechanism still relied on spawning an ephemeral helper container over gRPC (gateway.v0).frontend grpc server closed unexpectedly).Instead of attempting to patch the parser on top of an outdated host daemon, we spin up a dedicated, standalone modern BuildKit daemon container:
setup-buildxstep indeployment/build-and-stage.yaml:docker buildx create --name osv-builder --use --driver-opt network=host.moby/buildkitcontainer with modern BuildKit and native--build-contextsupport.docker-configVolume:/root/.dockeracross allbuildxsteps so each step container seamlessly connects to and reuses theosv-builderinstance.--loadFlag:docker pushsteps work without modification.# syntax=headers:go/Dockerfileandgo/cmd/osv-linter-worker/Dockerfilesince the modern BuildKit instance handles--build-contextnatively without needing external gateway containers.