Skip to content
Navigation Menu
Sign in
Appearance settings
Platform
AI CODE CREATION
GitHub Copilot
Write better code with AI
GitHub Copilot app
Direct agents from issue to merge
MCP Registry
Integrate external tools
DEVELOPER WORKFLOWS
Actions
Automate any workflow
Codespaces
Instant dev environments
Issues
Plan and track work
Code Review
Manage code changes
Code Quality
Enforce quality at merge
APPLICATION SECURITY
GitHub Advanced Security
Find and fix vulnerabilities
Code security
Secure your code as you build
Secret protection
Stop leaks before they start
EXPLORE
Why GitHub
Documentation
Blog
Changelog
Marketplace
View all features
Solutions
BY COMPANY SIZE
Enterprises
Small and medium teams
Startups
Nonprofits
BY USE CASE
App Modernization
DevSecOps
DevOps
CI/CD
View all use cases
BY INDUSTRY
Healthcare
Financial services
Manufacturing
Government
View all industries
View all solutions
Resources
EXPLORE BY TOPIC
AI
Software Development
DevOps
Security
View all topics
EXPLORE BY TYPE
Customer stories
Events & webinars
Ebooks & reports
Business insights
GitHub Skills
SUPPORT & SERVICES
Documentation
Customer support
Community forum
Trust center
Partners
View all resources
Open Source
COMMUNITY
GitHub Sponsors
Fund open source developers
PROGRAMS
Security Lab
Maintainer Community
Accelerator
GitHub Stars
Archive Program
REPOSITORIES
Topics
Trending
Collections
Enterprise
ENTERPRISE SOLUTIONS
Enterprise platform
AI-powered developer platform
AVAILABLE ADD-ONS
GitHub Advanced Security
Enterprise-grade security features
Copilot for Business
Enterprise-grade AI features
Premium Support
Enterprise-grade 24/7 support
Pricing
Search
/
Sign in
Sign up
Appearance settings
You signed in with another tab or window.
Reload
to refresh your session.
You signed out in another tab or window.
Reload
to refresh your session.
You switched accounts on another tab or window.
Reload
to refresh your session.
Dismiss alert
{{ message }}
Uh oh!
There was an error while loading.
Please reload this page
.
google
/
pprof
Public
Notifications
You must be signed in to change notification settings
Fork
669
Star
9.3k
Code
Issues
49
Pull requests
11
Actions
Security and quality
0
Insights
Additional navigation options
Code
Issues
Pull requests
Actions
Security and quality
Insights
Escape Nodelet/tag names for Dot as well
- #568
#568
Open
NHDaly
wants to merge 10 commits into
google:main
google/pprof:main
from
NHDaly:nhd-dotgraph-escape-labels--escape-Tags
NHDaly/pprof:nhd-dotgraph-escape-labels--escape-Tags
Copy head branch name to clipboard
Conversation
Commits
10
(10)
Checks
Files changed
Open
Escape Nodelet/tag names for Dot as well
#568
NHDaly
wants to merge 10 commits into
google:main
google/pprof:main
from
NHDaly:nhd-dotgraph-escape-labels--escape-Tags
NHDaly/pprof:nhd-dotgraph-escape-labels--escape-Tags
Copy head branch name to clipboard
Commits
Commits on Oct 3, 2020
Add missing `escapeForDot()` to labels for function names
Show description for 0b75a10
NHDaly
committed
0b75a10
View commit details
Copy full SHA for 0b75a10
Browse repository at this point
Add separate test for name escaping
NHDaly
committed
866a19c
View commit details
Copy full SHA for 866a19c
Browse repository at this point
Apply `escapeStringForDot()` in more places, to cover more cases of potentially harmful string labels.
Show description for 5d0860e
NHDaly
committed
5d0860e
View commit details
Copy full SHA for 5d0860e
Browse repository at this point
gofmt cleanups
NHDaly
committed
04c65fd
View commit details
Copy full SHA for 04c65fd
Browse repository at this point
Cleanup: Remove commented out line
NHDaly
committed
72389be
View commit details
Copy full SHA for 72389be
Browse repository at this point
Commits on Oct 5, 2020
Rename escapeForDot => escapeAllForDot; escapeStringForDot => escapeForDot
NHDaly
committed
dff1afc
View commit details
Copy full SHA for dff1afc
Browse repository at this point
Add (failing) test of Tag with `"` in name
NHDaly
committed
956deb6
View commit details
Copy full SHA for 956deb6
Browse repository at this point
Escape Nodelet/tag names for Dot as well.
Show description for ce716bd
NHDaly
committed
ce716bd
View commit details
Copy full SHA for ce716bd
Browse repository at this point
Add justify option to escapeForDot to preserve old behavior
Show description for e739e7e
NHDaly
committed
e739e7e
View commit details
Copy full SHA for e739e7e
Browse repository at this point
Unexport dotJustifyType since it's only meant to be used for dotgraph.
NHDaly
committed
8c597aa
View commit details
Copy full SHA for 8c597aa
Browse repository at this point
You can’t perform that action at this time.