Skip to content

fix: Don't overwrite early address validation tokens#97

Open
nico5300 wants to merge 1 commit into
google:mainfrom
nico5300:avt-fix
Open

fix: Don't overwrite early address validation tokens#97
nico5300 wants to merge 1 commit into
google:mainfrom
nico5300:avt-fix

Conversation

@nico5300

Copy link
Copy Markdown

Hello,
this is a re-issue of PR #87, fixing #54, as I deleted my previous repository. This PR contains the same fix for a bug in the way quiche handles address validation tokens. Please refer to #87 for a detailled description. Thanks and sorry for the confusion.

@nshapovalov

Copy link
Copy Markdown

Thanks for picking this up! The fix matches the maintainer guidance on #54.

Two things that might help get this merged:

  1. Rebase onto current main to resolve the merge conflict (PR shows as "dirty")
  2. Add a unit test for the NEW_TOKEN-before-ticket scenario in quic_client_session_cache_test.cc
  3. Email quiche-contribution@google.com with this PR link (per CONTRIBUTING.md)

@yangfanud — would you or someone on the team be able to review when rebased?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants