Skip to content

fix AutoRelay default zero value#129

Merged
aojea merged 3 commits into
google:mainfrom
aojea:autopudate
Jun 21, 2026
Merged

fix AutoRelay default zero value#129
aojea merged 3 commits into
google:mainfrom
aojea:autopudate

Conversation

@aojea

@aojea aojea commented Jun 21, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds AutoRelay configuration fields (AutoRelayMinInterval, AutoRelayBootDelay, and AutoRelayBackoff) to some NewSamNode instantiations in cmd/sam-node/main.go and updates an integration test. However, the reviewer noted that these fields are missing from other NewSamNode calls in the same file, specifically the post-enrollment and join command instances, which would cause them to fall back to zero values.

Comment thread cmd/sam-node/main.go
@aojea

aojea commented Jun 21, 2026

Copy link
Copy Markdown
Collaborator Author

/gemini review again

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request configures auto-relay parameters (AutoRelayMinInterval, AutoRelayBootDelay, and AutoRelayBackoff) during mesh node initialization across different commands in cmd/sam-node/main.go, and updates an integration test parameter in tests/integration/failover_test.go. A review comment correctly identifies that these flags are not registered under the join command, which would cause them to default to zero values. It is recommended to pass safe default values directly for the join command initialization.

Comment thread cmd/sam-node/main.go Outdated
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@aojea aojea merged commit fe732c4 into google:main Jun 21, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant