[ci] Keep read-only checks from rewriting lockfiles - #3516
Open
joshlf wants to merge 1 commit into
Open
Conversation
This was referenced Jul 31, 2026
joshlf
force-pushed
the
Gr5dxmcwfct6ij22jsf3sevpdetlzlcuz
branch
from
July 31, 2026 23:23
3538a08 to
fc717ce
Compare
joshlf
force-pushed
the
Gb7xokkyivphxcgxt7f2k2lyap32oa7kv
branch
from
July 31, 2026 23:23
2e680ed to
29ab67e
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## Gr5dxmcwfct6ij22jsf3sevpdetlzlcuz #3516 +/- ##
==================================================================
Coverage 91.85% 91.85%
==================================================================
Files 20 20
Lines 6093 6093
==================================================================
Hits 5597 5597
Misses 496 496 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
joshlf
force-pushed
the
Gr5dxmcwfct6ij22jsf3sevpdetlzlcuz
branch
from
July 31, 2026 23:39
fc717ce to
f7e1231
Compare
joshlf
force-pushed
the
Gb7xokkyivphxcgxt7f2k2lyap32oa7kv
branch
from
July 31, 2026 23:39
29ab67e to
438934f
Compare
joshlf
force-pushed
the
Gr5dxmcwfct6ij22jsf3sevpdetlzlcuz
branch
from
July 31, 2026 23:45
f7e1231 to
ba38f94
Compare
joshlf
force-pushed
the
Gb7xokkyivphxcgxt7f2k2lyap32oa7kv
branch
2 times, most recently
from
July 31, 2026 23:54
01787d5 to
91f1559
Compare
joshlf
force-pushed
the
Gr5dxmcwfct6ij22jsf3sevpdetlzlcuz
branch
2 times, most recently
from
August 1, 2026 00:04
0b7d536 to
cbd2d66
Compare
joshlf
force-pushed
the
Gb7xokkyivphxcgxt7f2k2lyap32oa7kv
branch
from
August 1, 2026 00:04
91f1559 to
f149ae5
Compare
Treat each first-party `Cargo.lock` as an input to validation. Make `cargo-zerocopy` add `--locked` by default, add the inner flag to Cargo plugins that parse their own arguments, and use locked, offline metadata where dependency resolution is unnecessary. Pin `cargo-readme` exactly and reject the wrong executable before generation. Build the Anneal dependency-cache image from its real workspace manifests so the repository lockfile can be enforced. Guard all five first-party lockfiles around pre-push checks. Reap every parallel child even after failures, then report any lockfile changed by a nominally read-only check. Discover the inventory dynamically so new workspaces are protected automatically. Bootstrap and developer-tool workspaces intentionally remain online: a fresh checkout may need to fetch exact packages recorded in their lockfiles. Nested Anneal builds of external user projects also remain online. These operations use `--locked` but not `--offline`; release scripts that deliberately regenerate lockfiles remain mutable. Add focused tests for wrapper argument placement, generator failures, the Anneal Docker contract, lockfile coverage, and complete child reaping. gherrit-pr-id: Gb7xokkyivphxcgxt7f2k2lyap32oa7kv
joshlf
force-pushed
the
Gr5dxmcwfct6ij22jsf3sevpdetlzlcuz
branch
from
August 1, 2026 00:08
cbd2d66 to
c40fe8b
Compare
joshlf
force-pushed
the
Gb7xokkyivphxcgxt7f2k2lyap32oa7kv
branch
from
August 1, 2026 00:08
f149ae5 to
0220455
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Treat each first-party
Cargo.lockas an input to validation. Makecargo-zerocopyadd--lockedby default, add the inner flag to Cargoplugins that parse their own arguments, and use locked, offline
metadata where dependency resolution is unnecessary.
Pin
cargo-readmeexactly and reject the wrong executable beforegeneration. Build the Anneal dependency-cache image from its real
workspace manifests so the repository lockfile can be enforced.
Guard all five first-party lockfiles around pre-push checks. Reap every
parallel child even after failures, then report any lockfile changed by
a nominally read-only check. Discover the inventory dynamically so new
workspaces are protected automatically.
Bootstrap and developer-tool workspaces intentionally remain online: a
fresh checkout may need to fetch exact packages recorded in their
lockfiles. Nested Anneal builds of external user projects also remain
online. These operations use
--lockedbut not--offline; releasescripts that deliberately regenerate lockfiles remain mutable.
Add focused tests for wrapper argument placement, generator failures,
the Anneal Docker contract, lockfile coverage, and complete child
reaping.
Latest Update: v7 — Compare vs v6
📚 Full Patch History
Links show the diff between the row version and the column version.
⬇️ Download this PR
Branch
git fetch origin refs/heads/Gb7xokkyivphxcgxt7f2k2lyap32oa7kv && git checkout -b pr-Gb7xokkyivphxcgxt7f2k2lyap32oa7kv FETCH_HEADCheckout
git fetch origin refs/heads/Gb7xokkyivphxcgxt7f2k2lyap32oa7kv && git checkout FETCH_HEADCherry Pick
git fetch origin refs/heads/Gb7xokkyivphxcgxt7f2k2lyap32oa7kv && git cherry-pick FETCH_HEADPull
Stacked PRs enabled by GHerrit.