fix(bq_driver): Asan CI check fix with less lsan entries - #1629
Draft
KanchanShu wants to merge 5 commits into
Draft
fix(bq_driver): Asan CI check fix with less lsan entries#1629KanchanShu wants to merge 5 commits into
KanchanShu wants to merge 5 commits into
Conversation
KanchanShu
force-pushed
the
test_asan_fix
branch
from
August 11, 2026 18:18
414bf39 to
a3dabca
Compare
KanchanShu
changed the title
| leak:_iodbcdm_SetConnectOption_init | ||
| leak:_iodbcdm_driverunload | ||
| leak:_iodbcdm_pushsqlerr | ||
| leak:SQLAllocStmt_Internal |
Collaborator
There was a problem hiding this comment.
these looks like a clear memory leak in our driver SQLAllocStmt_Internal, SQLAllocConnect_Internal, SQLAllocEnv_Internal. We will never suppress these
| leak:StatusRecord | ||
| leak:std::__cxx11::basic_string | ||
| leak:_iodbcdm_SetConnectOption_init | ||
| leak:_iodbcdm_driverunload |
Collaborator
There was a problem hiding this comment.
Please give the stack trace and reasoning why we are suppressing these other leaks?
| } | ||
| } | ||
|
|
||
| void StatementHandle::WaitForAsyncOperations() { |
Collaborator
There was a problem hiding this comment.
this looks a bit risky, do we have any way in any case it will not cause deadlock?
Collaborator
Author
There was a problem hiding this comment.
removed the block
KanchanShu
force-pushed
the
test_asan_fix
branch
from
August 12, 2026 15:53
8ebc9d4 to
484fa9f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.