test skipping permission - #1631
Closed
Anshu6250 wants to merge 2 commits into
Closed
Conversation
| auto const& status = tables_status.GetStatusRecord(); | ||
|
|
||
| if (IsTableNotFound(status)) { | ||
| if (IsTableNotFound(status) || status.native_error_code == 403) { |
Collaborator
There was a problem hiding this comment.
Please add this error code in the same IsTableNotFound function itself
| bq_client.FilterDatasets(project_id, filter, options); | ||
| if (!datasets) { | ||
| auto const& status = datasets.GetStatusRecord(); | ||
| if (status.native_error_code == 404 || status.native_error_code == 403) { |
Collaborator
There was a problem hiding this comment.
same here move this IsTableNotFound function to utility and use everywhere
Anshu6250
force-pushed
the
test_skip_permission_err
branch
from
August 12, 2026 15:05
e4e2b87 to
ad24965
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.