Skip to content

feat(storage): Add more test coverage for initial read ranges in AsyncClient::Open() - #16357

Open
kalragauri wants to merge 4 commits into
googleapis:mainfrom
kalragauri:feat/open-range
Open

feat(storage): Add more test coverage for initial read ranges in AsyncClient::Open()#16357
kalragauri wants to merge 4 commits into
googleapis:mainfrom
kalragauri:feat/open-range

Conversation

@kalragauri

Copy link
Copy Markdown
Contributor

No description provided.

@product-auto-label product-auto-label Bot added the api: storage Issues related to the Cloud Storage API. label Aug 19, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces comprehensive unit and integration tests for multi-range pre-warming, caching, and teardown safety in ObjectDescriptorImpl and AsyncClient. The reviewer feedback focuses on aligning the new test code with the repository style guide, specifically by replacing Abseil types (absl::optional, absl::string_view) with their standard library equivalents (std::optional, std::string_view), avoiding the use of auto when it obscures StatusOr return types, and ensuring auto is properly qualified or replaced with explicit types in range-based loops.

Comment thread google/cloud/storage/internal/async/object_descriptor_impl_test.cc Outdated
Comment thread google/cloud/storage/internal/async/object_descriptor_impl_test.cc Outdated
Comment thread google/cloud/storage/internal/async/object_descriptor_impl_test.cc Outdated
Comment thread google/cloud/storage/internal/async/object_descriptor_impl_test.cc Outdated
Comment thread google/cloud/storage/internal/async/object_descriptor_impl_test.cc Outdated
Comment thread google/cloud/storage/tests/async_client_integration_test.cc Outdated
Comment thread google/cloud/storage/tests/async_client_integration_test.cc Outdated
Comment thread google/cloud/storage/tests/async_client_integration_test.cc Outdated
Comment thread google/cloud/storage/tests/async_client_integration_test.cc Outdated
Comment thread google/cloud/storage/tests/async_client_integration_test.cc Outdated
@kalragauri
kalragauri marked this pull request as ready for review August 19, 2026 04:42
@kalragauri
kalragauri requested review from a team as code owners August 19, 2026 04:42
@kalragauri
kalragauri requested a review from v-pratap August 19, 2026 04:43
@codecov

codecov Bot commented Aug 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.24%. Comparing base (a20125d) to head (c92f832).

Additional details and impacted files
@@           Coverage Diff            @@
##             main   #16357    +/-   ##
========================================
  Coverage   92.24%   92.24%            
========================================
  Files        2227     2227            
  Lines      209614   209810   +196     
========================================
+ Hits       193351   193549   +198     
+ Misses      16263    16261     -2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the Cloud Storage API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant