-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat(bigquery-jdbc): implement TypeRegistry and TypeDescriptor #13947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Neenu1995
wants to merge
9
commits into
main
Choose a base branch
from
feat/type-registry-phase-1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
436c18e
feat(bigquery-jdbc): implement TypeRegistry and TypeDescriptor
Neenu1995 efb8327
fix(bigquery-jdbc): restrict visibility to package-private
Neenu1995 c23e0ce
redesign TypeRegistry
Neenu1995 657852f
fix(bigquery-jdbc): use BigQueryJdbcException instead of generic SQLE…
Neenu1995 62800cf
lint
Neenu1995 94fd293
timeZoneUtility
Neenu1995 536df8b
feat: core type registry matrix (Phase 1)
Neenu1995 69aaa79
refactor the static block
Neenu1995 83803da
lint
Neenu1995 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
115 changes: 115 additions & 0 deletions
115
java-bigquery-jdbc/src/main/java/com/google/cloud/bigquery/jdbc/BigQueryTemporalUtility.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,115 @@ | ||
| /* | ||
| * Copyright 2026 Google LLC | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * https://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package com.google.cloud.bigquery.jdbc; | ||
|
|
||
| import java.sql.Date; | ||
| import java.sql.Time; | ||
| import java.sql.Timestamp; | ||
| import java.time.Instant; | ||
| import java.time.LocalDate; | ||
| import java.time.LocalDateTime; | ||
| import java.time.LocalTime; | ||
| import java.time.ZoneId; | ||
| import java.util.Calendar; | ||
|
|
||
| /** | ||
| * A highly optimized utility for bridging BigQuery's civil time and absolute time semantics to | ||
| * legacy JDBC Date/Time/Timestamp classes using JSR-310 timezone anchoring. | ||
| */ | ||
| final class BigQueryTemporalUtility { | ||
|
|
||
| private BigQueryTemporalUtility() {} | ||
|
|
||
| /** | ||
| * Converts a BigQuery civil DATETIME string into an absolute Timestamp by anchoring it to the | ||
| * provided timezone (or JVM default if null). | ||
| */ | ||
| public static Timestamp boxDateTime(String val, ZoneId zoneId) { | ||
| ZoneId targetZone = zoneId != null ? zoneId : ZoneId.systemDefault(); | ||
| String isoString = val.replace(' ', 'T'); | ||
| return Timestamp.from(LocalDateTime.parse(isoString).atZone(targetZone).toInstant()); | ||
| } | ||
|
|
||
| /** | ||
| * Converts a BigQuery civil DATE string into an absolute Date by anchoring it to midnight of the | ||
| * provided timezone (or JVM default if null). | ||
| */ | ||
| public static Date boxDate(String val, ZoneId zoneId) { | ||
| ZoneId targetZone = zoneId != null ? zoneId : ZoneId.systemDefault(); | ||
| return new Date(LocalDate.parse(val).atStartOfDay(targetZone).toInstant().toEpochMilli()); | ||
| } | ||
|
|
||
| /** | ||
| * Converts a BigQuery civil TIME string into an absolute Time. If a ZoneId is provided (e.g. from | ||
| * the legacy JDBC 3.0 getTime(col, Calendar) API), this uses legacy Calendar manipulation to | ||
| * strictly mimic older JVM historical DST quirks for 1970. If no ZoneId is provided (e.g. modern | ||
| * JDBC 4.2 getObject(col, LocalTime.class)), this uses pure JSR-310 math which guarantees | ||
| * perfectly accurate modern conversions. | ||
| */ | ||
| public static Time boxTime(String val, ZoneId zoneId) { | ||
| LocalTime localTime = LocalTime.parse(val); | ||
|
|
||
| if (zoneId == null) { | ||
| // JDBC 4.2 Modern API (no Calendar provided): | ||
| // Use pure JSR-310 math for perfectly accurate modern conversions without Calendar quirks. | ||
| return new Time( | ||
| localTime | ||
| .atDate(LocalDate.of(1970, 1, 1)) | ||
| .atZone(ZoneId.systemDefault()) | ||
| .toInstant() | ||
| .toEpochMilli()); | ||
| } | ||
|
|
||
| // Legacy JDBC 3.0 API (Calendar provided): | ||
| // Use legacy Calendar manipulation to intentionally replicate old JVM historical DST quirks | ||
| // for January 1, 1970, ensuring strict backwards compatibility for legacy ORMs. | ||
| Calendar targetCal = Calendar.getInstance(java.util.TimeZone.getTimeZone(zoneId)); | ||
| targetCal.set(Calendar.YEAR, 1970); | ||
| targetCal.set(Calendar.MONTH, Calendar.JANUARY); | ||
| targetCal.set(Calendar.DAY_OF_MONTH, 1); | ||
| targetCal.set(Calendar.HOUR_OF_DAY, localTime.getHour()); | ||
| targetCal.set(Calendar.MINUTE, localTime.getMinute()); | ||
| targetCal.set(Calendar.SECOND, localTime.getSecond()); | ||
| targetCal.set(Calendar.MILLISECOND, localTime.getNano() / 1_000_000); | ||
|
|
||
| return new Time(targetCal.getTimeInMillis()); | ||
| } | ||
|
|
||
| /** | ||
| * Converts a BigQuery absolute TIMESTAMP string into a legacy Timestamp. Because it is absolute, | ||
| * the Calendar timezone is explicitly ignored per JDBC 4.2 spec. | ||
| */ | ||
| public static Timestamp boxTimestamp(String val) { | ||
| String iso = val; | ||
| // Handle the " UTC" suffix format | ||
| if (iso.endsWith(" UTC")) { | ||
| iso = iso.substring(0, iso.length() - 4) + "Z"; | ||
| } | ||
| // Replace the date-time space separator with 'T' (e.g. 2023-10-01 12:00:00 -> | ||
| // 2023-10-01T12:00:00) | ||
| if (iso.length() > 10 && iso.charAt(10) == ' ') { | ||
| iso = iso.substring(0, 10) + 'T' + iso.substring(11); | ||
| } | ||
|
|
||
| try { | ||
| return Timestamp.from(Instant.parse(iso)); | ||
| } catch (java.time.format.DateTimeParseException e) { | ||
| // Fallback for non-standard formats | ||
| return Timestamp.valueOf(val); | ||
| } | ||
| } | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this is where I'm not 100% sure about the behavior.
We have 4 time-related types: timestamp, time, date, datetime.
Time, Date, Datetime are not timezone specific, so we should be reading them as-is. If it is stored as "12:30:00", it should remain "12:30:00" regardless of the JVM timezone or provided timezone.
Timestamp is the only value that needs to be adjusted to the timezone.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
java.sql.Datestores epoch millis under the hood, not civil year/month/day fields.getDate(col, cal)contract: Per JDBC spec, the returnedjava.sql.Datemust represent midnight (00:00:00) in the providedCalendar's timezone.2026-07-17displays as2026-07-16 20:00in New York time).(Note: Modern
LocalDateviagetObject(col, LocalDate.class)is already timezone-agnostic and read as-is without any conversion).getObject(col, LocalDate.class)java.time.LocalDategetObject(col, LocalTime.class)java.time.LocalTimegetDate(col)java.sql.DategetDate(col, Calendar cal)java.sql.DateCalendartimezonegetTimestamp(col, Calendar cal)java.sql.TimestampCalendartimezone