deps: Upgrade grpc-java to 1.83.0 - #13967
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request bumps the version numbers of numerous Google Cloud Java client libraries across their respective README.md files, typically incrementing the minor or patch versions. Additionally, it upgrades the gRPC dependency version from 1.82.2 to 1.83.0 in grpc-gcp-java/pom.xml, librarian.yaml, and sdk-platform-java/gapic-generator-java-pom-parent/pom.xml. I have no feedback to provide as these are standard dependency and documentation version updates.
253045e to
10e8a8f
Compare
|
Probably blocked by #13976 |
…ble writes and read channels (#13976) Found when upgradeing gRPC to v1.83.0 (as consequently Gson to v2.14.0) from #13967 Error: ``` 18:19:21:843 [ERROR] Errors: 18:19:21:843 [ERROR] SerializationTest>BaseSerializationTest.testRestorableObjects:67->BaseSerializationTest.serializeAndDeserialize:82 » JsonSyntax duplicate key: bucket ``` Seems to stem from Gson PR [#3006](google/gson#3006) which added strict duplicate key detection in MapTypeAdapterFactory.Adapter.read ('if (map.containsKey(key)) throw ...'). Possible Fix: Since com.google.api.services.storage.model.StorageObject extends com.google.api.client.util.GenericData (which implements java.util.Map), raw Gson selects MapTypeAdapterFactory when serializing and deserializing StorageObject. However, GenericData.containsKey returns true for all @key annotated fields even before they are set, causing raw Gson.fromJson to throw JsonSyntaxException ('duplicate key') when deserializing StorageObject. PR to replaces raw Gson serialization and deserialization of StorageObject in ApiaryReadRequest and JsonResumableWrite with Google API Client's official JSON parser/serializer via JsonUtils (backed by JsonObjectParser / GsonFactory), resolving the duplicate key deserialization failure in SerializationTest. Co-authored-by: Dhriti07 <56169283+Dhriti07@users.noreply.github.com>
|
|
1 participant
No description provided.