refactor(bigquerystorage): move all integration tests to google-cloud-bigquerystorage-it - #13988
refactor(bigquerystorage): move all integration tests to google-cloud-bigquerystorage-it#13988jinseopkim0 wants to merge 9 commits into
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a new integration testing module, google-cloud-bigquerystorage-it, and moves the google-cloud-bigquery test dependency from the main storage module to this new integration test module. The feedback suggests managing the avro dependency version in the parent POM's <dependencyManagement> section rather than hardcoding it in the child module's pom.xml to ensure consistency.
87a4c10 to
03542e5
Compare
…x Arrow allocator errors
…to fix GraalVM test failures
…iguration in bigquerystorage-it to fix MemoryUtil init errors on JDK 17+
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| syntax = "proto2"; |
There was a problem hiding this comment.
not something we need to do in this PR, but I think we probably should convert this to proto3 at some time. Maybe we should create a ticket in the backlog
|
I think the changes do make sense. This breaks the dependence from BQStorage -> BQ. Now IIUC the dependency graph is BQ depends on BQStorage (compile), BQStorage-It depends on BQStorage and BQ (test scope for both), BQStorage doesn't depend on anything. Is this correct for the dependency graph? |
Moves all 22 integration test classes and helper/proto resources from
google-cloud-bigquerystorageinto a dedicated downstream integration test module (google-cloud-bigquerystorage-it).Motivation
google-cloud-bigqueryfromgoogle-cloud-bigquerystorage..protoschema duplication betweenjava-bigqueryandjava-bigquerystorage.google-cloud-bigquerystorageandgoogle-cloud-bigquery.Kokoro CIs show that the migrated tests are running.
b/500459077