Skip to content

refactor(bigquerystorage): move all integration tests to google-cloud-bigquerystorage-it - #13988

Open
jinseopkim0 wants to merge 9 commits into
mainfrom
create-bigquerystorage-it-module
Open

refactor(bigquerystorage): move all integration tests to google-cloud-bigquerystorage-it#13988
jinseopkim0 wants to merge 9 commits into
mainfrom
create-bigquerystorage-it-module

Conversation

@jinseopkim0

@jinseopkim0 jinseopkim0 commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Moves all 22 integration test classes and helper/proto resources from google-cloud-bigquerystorage into a dedicated downstream integration test module (google-cloud-bigquerystorage-it).

Motivation

  • Removes the test-scope dependency on google-cloud-bigquery from google-cloud-bigquerystorage.
  • Prevents test code and .proto schema duplication between java-bigquery and java-bigquerystorage.
  • Consolidates all end-to-end integration tests in a dedicated downstream module that depends on both google-cloud-bigquerystorage and google-cloud-bigquery.

Kokoro CIs show that the migrated tests are running.

b/500459077

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new integration testing module, google-cloud-bigquerystorage-it, and moves the google-cloud-bigquery test dependency from the main storage module to this new integration test module. The feedback suggests managing the avro dependency version in the parent POM's <dependencyManagement> section rather than hardcoding it in the child module's pom.xml to ensure consistency.

Comment thread java-bigquerystorage/google-cloud-bigquerystorage-it/pom.xml
@jinseopkim0
jinseopkim0 force-pushed the create-bigquerystorage-it-module branch from 87a4c10 to 03542e5 Compare August 4, 2026 23:08
@jinseopkim0
jinseopkim0 marked this pull request as ready for review August 5, 2026 14:40
@jinseopkim0
jinseopkim0 requested review from a team as code owners August 5, 2026 14:40
@jinseopkim0
jinseopkim0 requested a review from lqiu96 August 5, 2026 14:40
* See the License for the specific language governing permissions and
* limitations under the License.
*/
syntax = "proto2";

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not something we need to do in this PR, but I think we probably should convert this to proto3 at some time. Maybe we should create a ticket in the backlog

@lqiu96

lqiu96 commented Aug 7, 2026

Copy link
Copy Markdown
Member

I think the changes do make sense. This breaks the dependence from BQStorage -> BQ.

Now IIUC the dependency graph is BQ depends on BQStorage (compile), BQStorage-It depends on BQStorage and BQ (test scope for both), BQStorage doesn't depend on anything.

Is this correct for the dependency graph?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants