Repository navigation
fix(api-common): validate path template variables against dot segments - #14641
Merged
blakeli0 merged 4 commits intoOct 16, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request replaces URLEncoder with Guava's PercentEscaper for URL encoding and introduces validation to reject path segments that are exactly '.' or '..' during template instantiation. It also adds comprehensive unit tests to verify these validation rules. The review feedback suggests optimizing the hasPathWildcard helper method by breaking out of the loop early once a path wildcard is found.
lqiu96
reviewed
Oct 14, 2026
lqiu96
reviewed
Oct 14, 2026
lqiu96
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validates URI path template variable segments during
PathTemplate.instantiateto prevent unintended dot-segment ("."and"..") path traversal and ensures strict percent-encoding of non-unreserved URI characters:"."or".."in single-segment (*), multi-segment (*), and path wildcard (**) bindings (ValidationException: "Value for %s must not contain segments that are exactly . or ..").PercentEscaper("-_.~", false)so all characters outside[-_.~0-9a-zA-Z]are percent-encoded (e.g., spaces as%20,?as%3F,#as%23,%as%25).fixes: b/545212190