Repository navigation
feat(generator): surface actionable errors at upload call time for unsupported or failed setup - #14653
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the resumable upload stub generation and implementation to check if resumable upload is supported, returning a failing callable if it is not. It refactors the stub constructors to accept the callables and background resources directly rather than instantiating them internally, and updates the generator class HttpJsonServiceResumableUploadStubClassComposer accordingly. Feedback on the generator suggests passing resumableUploadMethods to createConstructorMethods and iterating over them to ensure the generated constructor parameter order deterministically matches the argument order in createStaticCreatorMethods, rather than relying on the iteration order of callableClassMembers.values().
4e04be2 to
653c982
Compare
653c982 to
fb386f8
Compare
fb386f8 to
c25faa0
Compare
whowes
changed the title
whowes
changed the title
whowes
changed the title
c25faa0 to
8c4e10b
Compare
8c4e10b to
131ca43
Compare
131ca43 to
3660d63
Compare
…hannel is customized
3660d63 to
265ad36
Compare
|
|
This branch has not been deployed
1 participant
Updates generated HttpJson[Service]ResumableUploadStub.create() to build its HTTP/JSON ClientContext with ResumableUploadTransportBridge.createUploadClientContext(), replacing the generated transport check and deriveHttpJsonClientContext(). Upload failures on gRPC clients with customized transport providers now include an actionable hint.
Creating the upload stub's HTTP/JSON ClientContext is also a deferred failure: if it throws, upload calls fail with the original exception as the cause instead of failing stub creation, so client initialization and non-upload RPCs are not blocked.