Repository navigation
Conversation
Add the `isDataAvailable()` streaming contract to `StreamingResultSet` and forward it through `StreamingUtil` and `ForwardingResultSet`. This contract allows callers (such as `AsyncResultSetImpl`) to inspect whether a row, stream chunk, terminal EOF, or error is available immediately without blocking the calling thread on network I/O. Key changes: - `StreamingResultSet`: Defined `@InternalApi default boolean isDataAvailable()`, returning `true` by default for backward compatibility with synchronous and non-streaming implementations. - `StreamingUtil`: Added null-safe `static boolean isDataAvailable(ResultSet)` to unwrap `StreamingResultSet` instances or default to `true`. - `ForwardingResultSet`: Overrode `isDataAvailable()` to delegate to the underlying result set. - Added comprehensive unit tests in `StreamingUtilTest` and `ForwardingResultSetTest` exercising all methods, delegation, try-with-resources lifecycle, and null handling.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces the isDataAvailable() method to the StreamingResultSet interface, allowing callers to check if data is available to read immediately without blocking on network I/O. The default implementation returns true for backward compatibility. The change also updates ForwardingResultSet and StreamingUtil to support this new method, and adds comprehensive unit tests in ForwardingResultSetTest and StreamingUtilTest to verify the behavior. There are no review comments to address, and I have no additional feedback to provide.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the
isDataAvailable()streaming contract toStreamingResultSetand forward it throughStreamingUtilandForwardingResultSet.This contract allows callers (such as
AsyncResultSetImpl) to inspect whether a row, stream chunk, terminal EOF, or error is available immediately without blocking the calling thread on network I/O.Key changes:
StreamingResultSet: Defined@InternalApi default boolean isDataAvailable(), returningtrueby default for backward compatibility with synchronous and non-streaming implementations.StreamingUtil: Added null-safestatic boolean isDataAvailable(ResultSet)to unwrapStreamingResultSetinstances or default totrue.ForwardingResultSet: OverrodeisDataAvailable()to delegate to the underlying result set.StreamingUtilTestandForwardingResultSetTestexercising all methods, delegation, try-with-resources lifecycle, and null handling.