Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request implements exponential backoff for retrying transport failures in RetryingVRpc and adds corresponding unit tests. The feedback highlights a potential NullPointerException if the operation deadline is null when calculating remaining time, suggesting a defensive check to default hasRemainingTime to true.
Comment on lines
+303
to
+306
| boolean hasRemainingTime = | ||
| context.getOperationInfo().getDeadline().timeRemaining(TimeUnit.MILLISECONDS) | ||
| - retryDelayMs | ||
| > 1; |
Contributor
There was a problem hiding this comment.
If the operation does not have a deadline configured, context.getOperationInfo().getDeadline() may return null. Calling timeRemaining on a null deadline will throw a NullPointerException. We should defensively check if the deadline is null and default hasRemainingTime to true in that case.
Suggested change
| boolean hasRemainingTime = | |
| context.getOperationInfo().getDeadline().timeRemaining(TimeUnit.MILLISECONDS) | |
| - retryDelayMs | |
| > 1; | |
| io.grpc.Deadline deadline = context.getOperationInfo().getDeadline(); | |
| boolean hasRemainingTime = | |
| deadline == null | |
| || deadline.timeRemaining(TimeUnit.MILLISECONDS) - retryDelayMs > 1; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack created with GitHub Stacks CLI • Give Feedback 💬