Repository navigation
test(spanner): unflake ITSqlMusicScriptTest - #14814
sakthivelmanii wants to merge 1 commit into
Conversation
KeyAwareChannel incorrectly attached routing hints to ExecuteSqlRequest calls inside Partitioned DML transactions when pinned to an affinity endpoint. The fix tracks Partitioned DML transaction IDs from BeginTransaction options so routeFromRequest(ExecuteSqlRequest) skips attaching routing hints for Partitioned DML queries.
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request ensures that routing hints are never attached to Partitioned DML requests in KeyAwareChannel. It introduces a cache to track Partitioned DML transaction IDs and bypasses attaching routing hints for these transactions, routing them to the affinity or default endpoint instead. A unit test has been added to verify this behavior. I have no feedback to provide.
There was a problem hiding this comment.
Code Review
This pull request ensures that Partitioned DML transactions do not carry routing hints by introducing a cache to track Partitioned DML transaction IDs in KeyAwareChannel. Requests for these transactions are routed without a routing hint, preventing them from being executed on the fastpath which does not support Partitioned DML. A unit test has been added to verify this behavior. I have no feedback to provide on these changes.
Problem
KeyAwareChannelinadvertently attaches routing hints toExecuteSqlRequestcalls inside Partitioned DML transactions when pinned to an affinity endpoint.ExecuteStreamingSql) queries.Solution
KeyAwareChannelnow tracks Partitioned DML transaction IDs fromBeginTransactionoptions.routeFromRequest(ExecuteSqlRequest)skips attaching routing hints for Partitioned DML queries, resolving the issue.