chore(AnalyticsData): remove orphaned files from previous proto refactors - #9521
Open
sofisl wants to merge 1 commit into
Open
chore(AnalyticsData): remove orphaned files from previous proto refactors#9521sofisl wants to merge 1 commit into
sofisl wants to merge 1 commit into
Conversation
|
Here is the summary of changes. You are about to delete 1 region tag.
This comment is generated by snippet-bot.
|
sofisl
force-pushed
the
chore/remove-orphaned-analytics-data-files
branch
from
August 20, 2026 21:44
e48bf95 to
d40bd25
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes legacy/orphaned PHP files in
AnalyticsDatathat no longer correspond to upstreamgoogleapisdefinitions.Historically, when proto files or messages were renamed/moved in
googleapis, the PHP generator (via OwlBot) successfully generated the new files but failed to delete the old ones, leaving dead code in the repository. We discovered these while testing the newLibrarianmigration tool, which strictly cleans output directories and correctly flags these as deletions.Evidence & Tracing:
google/analytics/data/v1alpha/analytics_data_api.proto.googleapiscommit 97bcfbd777f7cdac49a5ee0c00ef6553000826ef, the upstream team explicitly removed theSheetExportAudienceListmethod and its associated resources.Safety / Backwards Compatibility Note:
Any customer code attempting to use these deleted classes is already broken and crashing in production.
Because the upstream
.protodefinitions were removed, the protobuf compiler previously removed these classes from the generatedGPBMetadatadescriptor pool. Because OwlBot left the PHP class files behind, they can still be referenced in code, but attempting to instantiate them immediately throws a Fatal PHP Exception before any API call is made.Example instantiation of an orphaned class:
Output:
Deleting these files simply cleans up the dead code and allows static analysis tools to correctly flag them as non-existent.
BREAKING_CHANGE_REASON=Removing legacy orphaned proto files that were left behind by OwlBot to ensure accurate 0-diff parity testing.
For googleapis/librarian#7366