chore(CloudCommonProtos): remove orphaned AttributeContext metadata - #9533
Open
sofisl wants to merge 2 commits into
Open
chore(CloudCommonProtos): remove orphaned AttributeContext metadata#9533sofisl wants to merge 2 commits into
sofisl wants to merge 2 commits into
Conversation
The `AttributeContext` proto correctly belongs to `CommonProtos`, not `CloudCommonProtos`. During the migration of common-protos to this repository in PR #7554, the metadata file was accidentally duplicated here, but the actual source classes were correctly placed in `CommonProtos`. This removes the useless orphaned metadata file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
AttributeContextproto correctly belongs toCommonProtos(which maps togoogle/rpc), notCloudCommonProtos(which maps togoogle/cloud/audit, etc.). During the migration of common-protos to this repository in PR #7554, the metadata file was accidentally duplicated here, but the actual source classes were correctly placed inCommonProtos.This orphaned metadata file creates a namespace collision when both packages are loaded, as shown in the test below:
Output on
mainwhen testing inCloudCommonProtos:However,
CloudCommonProtoslacks thesrcclass (Google\Rpc\Context\AttributeContext), which relies entirely onCommonProtos. Removing this duplicate file ensures themetadatais correctly loaded fromCommonProtos, resolving the shadow collision. Librarian correctly flagged this duplicate file for deletion.BREAKING_CHANGE_REASON=Removing legacy orphaned proto files that were left behind by OwlBot.
For googleapis/librarian#7366