chore(OsLogin): support common protos in owlbot.py and update generated files - #9547
Open
JoeWang1127 wants to merge 3 commits into
Open
chore(OsLogin): support common protos in owlbot.py and update generated files#9547JoeWang1127 wants to merge 3 commits into
JoeWang1127 wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OsLogin depends on unversioned protobuf message classes in the namespace
Google\Cloud\OsLogin\Common(such as PosixAccount and SshPublicKey),which are generated from
google/cloud/oslogin/common/common.proto.Previously, the Bazelbot/Owlbot generation pipeline was copying
Commonproto files:googleapis-genbundles all PHP proto files (CommonandV1) together undergoogle/cloud/oslogin/v1/google-cloud-oslogin-v1-php/proto/src/. BecauseCommonandV1are siblings in staging,synthtool's_find_copy_targetalgorithm visitsCommon/first, fails to matchversion_string="v1", and aborts the search, skipping bothCommonandV1proto copying.This change updates
OsLogin/owlbot.pyto:Commonproto and metadata directories out ofv1staging priorto calling
owlbot_main()in the legacy pipeline.common-protosviaphp.owlbot_copy_version()if stagedseparately by Librarian.
Also updates the generated
CommonandV1proto classes and metadata to the latest Protobuf 33.2 compiler output (using publicRepeatedFieldimports, typed array docblocks, and hex-escaped descriptor strings).The change to PHP code is generated by running Owlbot copy: