Skip to content

chore(Deploy): remove obsolete files - #9551

Open
sofisl wants to merge 1 commit into
mainfrom
feat/deploy
Open

chore(Deploy): remove obsolete files#9551
sofisl wants to merge 1 commit into
mainfrom
feat/deploy

Conversation

@sofisl

@sofisl sofisl commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

This PR removes obsolete structural files for Deploy that are no longer generated.

Testing Deletions

I attempted to load the deleted classes to prove they do not exist anymore.

Test Script:

<?php
require 'vendor/autoload.php';
echo "Testing deleted classes for Deploy...\n";
$success = true;
if (class_exists('Google\Cloud\Deploy\V1\\Range') || interface_exists('Google\Cloud\Deploy\V1\\Range') || trait_exists('Google\Cloud\Deploy\V1\\Range')) {
    echo "ERROR: Google\Cloud\Deploy\V1\\Range still exists!\n";
    $success = false;
} else {
    echo "SUCCESS: Google\Cloud\Deploy\V1\\Range does not exist.\n";
}
if (class_exists('Google\Cloud\Deploy\V1\\RepairMode') || interface_exists('Google\Cloud\Deploy\V1\\RepairMode') || trait_exists('Google\Cloud\Deploy\V1\\RepairMode')) {
    echo "ERROR: Google\Cloud\Deploy\V1\\RepairMode still exists!\n";
    $success = false;
} else {
    echo "SUCCESS: Google\Cloud\Deploy\V1\\RepairMode does not exist.\n";
}
if (class_exists('Google\Cloud\Deploy\V1\\RestrictRollout') || interface_exists('Google\Cloud\Deploy\V1\\RestrictRollout') || trait_exists('Google\Cloud\Deploy\V1\\RestrictRollout')) {
    echo "ERROR: Google\Cloud\Deploy\V1\\RestrictRollout still exists!\n";
    $success = false;
} else {
    echo "SUCCESS: Google\Cloud\Deploy\V1\\RestrictRollout does not exist.\n";
}
if (class_exists('Google\Cloud\Deploy\V1\RestrictRollout\\Actions') || interface_exists('Google\Cloud\Deploy\V1\RestrictRollout\\Actions') || trait_exists('Google\Cloud\Deploy\V1\RestrictRollout\\Actions')) {
    echo "ERROR: Google\Cloud\Deploy\V1\RestrictRollout\\Actions still exists!\n";
    $success = false;
} else {
    echo "SUCCESS: Google\Cloud\Deploy\V1\RestrictRollout\\Actions does not exist.\n";
}
if (class_exists('Google\Cloud\Deploy\V1\\TimeWindow') || interface_exists('Google\Cloud\Deploy\V1\\TimeWindow') || trait_exists('Google\Cloud\Deploy\V1\\TimeWindow')) {
    echo "ERROR: Google\Cloud\Deploy\V1\\TimeWindow still exists!\n";
    $success = false;
} else {
    echo "SUCCESS: Google\Cloud\Deploy\V1\\TimeWindow does not exist.\n";
}
if (!$success) exit(1);

Output:

Testing deleted classes for Deploy...
SUCCESS: Google\Cloud\Deploy\V1\Range does not exist.
SUCCESS: Google\Cloud\Deploy\V1\RepairMode does not exist.
SUCCESS: Google\Cloud\Deploy\V1\RestrictRollout does not exist.
SUCCESS: Google\Cloud\Deploy\V1\RestrictRollout\Actions does not exist.
SUCCESS: Google\Cloud\Deploy\V1\TimeWindow does not exist.

BREAKING_CHANGE_REASON=In google-cloud-php PR #7553, the cloud_deploy.proto was synced which removed the RepairMode message. OwlBot failed to delete this orphaned file.

For googleapis/librarian#7366

@sofisl
sofisl requested a review from a team as a code owner August 21, 2026 20:03
@product-auto-label product-auto-label Bot added the api: clouddeploy Issues related to the Cloud Deploy API. label Aug 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: clouddeploy Issues related to the Cloud Deploy API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant