Skip to content

fix(Dataform)!: remove obsolete LRO forwarding methods and formatting - #9554

Open
sofisl wants to merge 3 commits into
mainfrom
feat/format-fixes
Open

fix(Dataform)!: remove obsolete LRO forwarding methods and formatting#9554
sofisl wants to merge 3 commits into
mainfrom
feat/format-fixes

Conversation

@sofisl

@sofisl sofisl commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

This PR removes obsolete LRO forwarding methods from DataformClient and their corresponding samples, along with some formatting fixes generated by gapic-generator-php.

Testing Deletions

I attempted to call one of the deleted methods to prove it no longer exists on the client.

Test Script:

<?php
require 'vendor/autoload.php';
use Google\Cloud\Dataform\V1\Client\DataformClient;
use Google\LongRunning\CancelOperationRequest;

$client = new DataformClient();
echo "Testing deleted cancelOperation method on DataformClient...\n";
try {
    $client->cancelOperation(new CancelOperationRequest());
} catch (\Throwable $e) {
    echo "Error: " . $e->getMessage() . "\n";
}

Output:

Testing deleted cancelOperation method on DataformClient...
Error: Call to undefined method Google\Cloud\Dataform\V1\Client\DataformClient::cancelOperation()

BREAKING_CHANGE_REASON=In gapic-generator-php PR #834, the legacy V1 surface generation logic was removed. Previously, LRO methods like cancelOperation were erroneously forwarded on the main client class if google.longrunning.Operations was included as a mixin. The removal of the V1 surface stopped the generation of these methods, but OwlBot failed to delete them from google-cloud-php. Librarian correctly removes these obsolete wrappers. This is a true breaking change in the client's API surface; users who were calling $client->cancelOperation() must now migrate their code to call $client->getOperationsClient()->cancelOperation() (and it is currently still working).

Fixes googleapis/librarian#7369

@sofisl
sofisl requested a review from a team as a code owner August 21, 2026 20:33
@snippet-bot

snippet-bot Bot commented Aug 21, 2026

Copy link
Copy Markdown

Here is the summary of changes.

You are about to delete 8 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@sofisl
sofisl marked this pull request as draft August 21, 2026 20:56
@sofisl
sofisl force-pushed the feat/format-fixes branch from 4d038c2 to 2c3f94a Compare August 21, 2026 21:08
@sofisl sofisl changed the title chore: formatting fixes for ErrorReporting and Dataform chore: formatting fixes for Dataform Aug 21, 2026
@sofisl
sofisl force-pushed the feat/format-fixes branch from 2c3f94a to b88dc2f Compare August 21, 2026 21:24
@sofisl sofisl changed the title chore: formatting fixes for Dataform chore(Dataform): remove obsolete LRO forwarding methods and formatting Aug 21, 2026
@sofisl sofisl changed the title chore(Dataform): remove obsolete LRO forwarding methods and formatting fix(Dataform)!: remove obsolete LRO forwarding methods and formatting Aug 21, 2026
@sofisl
sofisl marked this pull request as ready for review August 21, 2026 21:37
@bshaffer bshaffer added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do not merge Indicates a pull request not ready for merge, due to either quality or timing.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

php: owlbot did not remove obsolete LRO methods in Dataform

2 participants