fix(Dataform)!: remove obsolete LRO forwarding methods and formatting - #9554
Open
sofisl wants to merge 3 commits into
Open
fix(Dataform)!: remove obsolete LRO forwarding methods and formatting#9554sofisl wants to merge 3 commits into
sofisl wants to merge 3 commits into
Conversation
|
Here is the summary of changes. You are about to delete 8 region tags.
This comment is generated by snippet-bot.
|
sofisl
marked this pull request as draft
August 21, 2026 20:56
sofisl
force-pushed
the
feat/format-fixes
branch
from
August 21, 2026 21:08
4d038c2 to
2c3f94a
Compare
sofisl
force-pushed
the
feat/format-fixes
branch
from
August 21, 2026 21:24
2c3f94a to
b88dc2f
Compare
sofisl
marked this pull request as ready for review
August 21, 2026 21:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes obsolete LRO forwarding methods from
DataformClientand their corresponding samples, along with some formatting fixes generated by gapic-generator-php.Testing Deletions
I attempted to call one of the deleted methods to prove it no longer exists on the client.
Test Script:
Output:
BREAKING_CHANGE_REASON=In
gapic-generator-phpPR #834, the legacy V1 surface generation logic was removed. Previously, LRO methods likecancelOperationwere erroneously forwarded on the main client class ifgoogle.longrunning.Operationswas included as a mixin. The removal of the V1 surface stopped the generation of these methods, but OwlBot failed to delete them fromgoogle-cloud-php. Librarian correctly removes these obsolete wrappers. This is a true breaking change in the client's API surface; users who were calling$client->cancelOperation()must now migrate their code to call$client->getOperationsClient()->cancelOperation()(and it is currently still working).Fixes googleapis/librarian#7369