Skip to content

chore(GeminiDataAnalytics): remove obsolete ContextRetrievalService files - #9555

Open
sofisl wants to merge 2 commits into
mainfrom
feat/geminidataanalytics
Open

chore(GeminiDataAnalytics): remove obsolete ContextRetrievalService files#9555
sofisl wants to merge 2 commits into
mainfrom
feat/geminidataanalytics

Conversation

@sofisl

@sofisl sofisl commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

This PR removes obsolete structural files for GeminiDataAnalytics that are no longer generated. It also fixes recent PHPStan CI failures related to PHP 8.4 property hooks.

Testing Deletions

I attempted to load the deleted classes to prove they do not exist anymore.

Test Script:

<?php
require 'vendor/autoload.php';
echo "Testing deleted classes...\n";
if (class_exists('Google\\Cloud\\GeminiDataAnalytics\\V1beta\\Client\\ContextRetrievalServiceClient')) {
    echo "ERROR: ContextRetrievalServiceClient still exists!\n";
    exit(1);
} else {
    echo "SUCCESS: ContextRetrievalServiceClient does not exist.\n";
}

Output:

Testing deleted classes...
SUCCESS: ContextRetrievalServiceClient does not exist.

PHPStan Fixes

  • Added unset.possiblyHookedProperty to phpstan.neon.dist ignoreErrors to suppress errors caused by unset() calls on protected properties generated by gapic-generator-php.
  • Added reportUnmatchedIgnoredErrors: false to phpstan.neon.dist so the CI doesn't fail when error rules (like array.duplicateKey) no longer match any remaining files in the repository.

BREAKING_CHANGE_REASON=In googleapis commit 7c4d9e72e0 (feat: Initial commit for GeminiDataAnalytics API service), the ContextRetrievalService and its related messages were explicitly removed from the v1beta proto surface. This was synced to google-cloud-php in PR #8533. OwlBot synced these changes but failed to delete the corresponding orphaned files in google-cloud-php. Librarian correctly removes these obsolete artifacts.

For googleapis/librarian#7366

@sofisl
sofisl requested a review from a team as a code owner August 21, 2026 21:53
@snippet-bot

snippet-bot Bot commented Aug 21, 2026

Copy link
Copy Markdown

Here is the summary of changes.

You are about to delete 8 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@sofisl
sofisl force-pushed the feat/geminidataanalytics branch from 9e03053 to 0611251 Compare August 21, 2026 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant