chore(GeminiDataAnalytics): remove obsolete ContextRetrievalService files - #9555
Open
sofisl wants to merge 2 commits into
Open
chore(GeminiDataAnalytics): remove obsolete ContextRetrievalService files#9555sofisl wants to merge 2 commits into
sofisl wants to merge 2 commits into
Conversation
|
Here is the summary of changes. You are about to delete 8 region tags.
This comment is generated by snippet-bot.
|
sofisl
force-pushed
the
feat/geminidataanalytics
branch
from
August 21, 2026 23:34
9e03053 to
0611251
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes obsolete structural files for GeminiDataAnalytics that are no longer generated. It also fixes recent PHPStan CI failures related to PHP 8.4 property hooks.
Testing Deletions
I attempted to load the deleted classes to prove they do not exist anymore.
Test Script:
Output:
PHPStan Fixes
unset.possiblyHookedPropertytophpstan.neon.distignoreErrorsto suppress errors caused byunset()calls onprotectedproperties generated bygapic-generator-php.reportUnmatchedIgnoredErrors: falsetophpstan.neon.distso the CI doesn't fail when error rules (likearray.duplicateKey) no longer match any remaining files in the repository.BREAKING_CHANGE_REASON=In googleapis commit 7c4d9e72e0 (feat: Initial commit for GeminiDataAnalytics API service), the
ContextRetrievalServiceand its related messages were explicitly removed from thev1betaproto surface. This was synced togoogle-cloud-phpin PR #8533. OwlBot synced these changes but failed to delete the corresponding orphaned files ingoogle-cloud-php. Librarian correctly removes these obsolete artifacts.For googleapis/librarian#7366