chore(GkeHub): remove obsolete FeatureSpec and orphaned samples - #9557
Open
sofisl wants to merge 1 commit into
Open
chore(GkeHub): remove obsolete FeatureSpec and orphaned samples#9557sofisl wants to merge 1 commit into
sofisl wants to merge 1 commit into
Conversation
|
Here is the summary of changes. You are about to delete 13 region tags.
This comment is generated by snippet-bot.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes obsolete structural files for GkeHub that are no longer generated.
Testing Deletions
I verified that the erroneously placed
FeatureSpecclass is no longer present, but the correctly placedFeatureSpecclasses in sub-namespaces still exist.Test Script:
Output:
BREAKING_CHANGE_REASON=
gapic-generator-phphistorically had a bug where it generated duplicate/orphaned messages in the rootV1namespace if they had sub-namespaces (likeGoogle\Cloud\GkeHub\MultiClusterIngress\V1). When googleapis commit aa4559a97f was synced in PR #6254, OwlBot failed to clean up thisGkeHub/src/V1/FeatureSpec.phpfile and left it orphaned. It also left behind orphaned sample files forV1beta1. Librarian correctly removes the duplicated file and the orphaned samples. This has no impact on users because the rootFeatureSpecwas never loadable via Composer PSR-4 anyway due to its namespace mismatch.For googleapis/librarian#7366