Skip to content

chore(GkeHub): remove obsolete FeatureSpec and orphaned samples - #9557

Open
sofisl wants to merge 1 commit into
mainfrom
feat/gkehub
Open

chore(GkeHub): remove obsolete FeatureSpec and orphaned samples#9557
sofisl wants to merge 1 commit into
mainfrom
feat/gkehub

Conversation

@sofisl

@sofisl sofisl commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

This PR removes obsolete structural files for GkeHub that are no longer generated.

Testing Deletions

I verified that the erroneously placed FeatureSpec class is no longer present, but the correctly placed FeatureSpec classes in sub-namespaces still exist.

Test Script:

<?php
require 'vendor/autoload.php';
echo "Testing deleted classes...\n";
if (class_exists('Google\Cloud\GkeHub\V1\FeatureSpec')) {
    echo "ERROR: Google\Cloud\GkeHub\V1\FeatureSpec still exists!\n";
    exit(1);
} else {
    echo "SUCCESS: Google\Cloud\GkeHub\V1\FeatureSpec does not exist.\n";
}
if (class_exists('Google\Cloud\GkeHub\MultiClusterIngress\V1\FeatureSpec')) {
    echo "SUCCESS: Google\Cloud\GkeHub\MultiClusterIngress\V1\FeatureSpec correctly exists.\n";
} else {
    echo "ERROR: Google\Cloud\GkeHub\MultiClusterIngress\V1\FeatureSpec is missing!\n";
    exit(1);
}

Output:

Testing deleted classes...
SUCCESS: Google\Cloud\GkeHub\V1\FeatureSpec does not exist.
SUCCESS: Google\Cloud\GkeHub\MultiClusterIngress\V1\FeatureSpec correctly exists.

BREAKING_CHANGE_REASON=gapic-generator-php historically had a bug where it generated duplicate/orphaned messages in the root V1 namespace if they had sub-namespaces (like Google\Cloud\GkeHub\MultiClusterIngress\V1). When googleapis commit aa4559a97f was synced in PR #6254, OwlBot failed to clean up this GkeHub/src/V1/FeatureSpec.php file and left it orphaned. It also left behind orphaned sample files for V1beta1. Librarian correctly removes the duplicated file and the orphaned samples. This has no impact on users because the root FeatureSpec was never loadable via Composer PSR-4 anyway due to its namespace mismatch.

For googleapis/librarian#7366

@sofisl
sofisl requested a review from a team as a code owner August 21, 2026 21:54
@snippet-bot

snippet-bot Bot commented Aug 21, 2026

Copy link
Copy Markdown

Here is the summary of changes.

You are about to delete 13 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label Bot added api: gkehub Issues related to the GKE Hub API API. samples Issues that are directly related to samples. labels Aug 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: gkehub Issues related to the GKE Hub API API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant