chore(Language): remove obsolete V1beta2 samples - #9558
Open
sofisl wants to merge 2 commits into
Open
Conversation
|
Here is the summary of changes. You are about to delete 7 region tags.
This comment is generated by snippet-bot.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes obsolete sample files for Language that are no longer generated.
Testing Deletions
No core library classes were deleted in this PR, only orphaned sample files. The
src/V1beta2surface was already deleted in a prior PR, but its corresponding samples were mistakenly left behind.Test Script:
Output:
When the
V1beta2surface was previously deprecated and removed fromgoogle-cloud-phpin PR #7385, OwlBot successfully deleted the coresrc/V1beta2directory but failed to clean up the associatedsamples/V1beta2directory. Librarian correctly removes these orphaned artifacts. There is no impact to the core client functionality since the underlying client code was already removed in the past.For googleapis/librarian#7366