Repository navigation
Update type hints for credentials in the async client layer #16268
Description
Activity
Transferring to google-cloud-python as the code for gapic-generator will be migrated there.
The async client will support sync credentials when using versions of auth that include #18542
We still need to update the types
Actually, I think we can close this out as complete, now that sync credentials are supported
async_rest supports either option. async_grpc only supports sync credentials. The common denominator is that sync credentials work everywhere, so we can keep that as the type hint
We can revisit this in the future, if we support async credentials for the grpc client, or have a reason to expose async credential support for just the http client
Update the credentials type hint in the async client constructor to include asynchronous credentials i.e. async credentials should also support
google.auth.aio.credentials.Credentialswhich are required by the async rest transport.For now, the type hint isn't updated in the client layer and mypy warnings are silenced by adding
# type: ignorein the async rest transport constructor. This can be looked up by searching for this issue.Related issue: #16269