feat(auth): add CertRotationInterceptor and MTLSRefreshingChannel for gRPC mTLS - #18556
Open
agrawalradhika-cell wants to merge 11 commits into
Open
agrawalradhika-cell wants to merge 11 commits into
agrawalradhika-cell wants to merge 11 commits into
Conversation
… gRPC mTLS Signed-off-by: Radhika Agrawal <agrawalradhika@google.com>
4 tasks done
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces an mTLS interceptor and channel wrapper (mtls_interceptor.py) along with comprehensive unit tests to handle automatic certificate rotation and retry logic for gRPC client calls. The review feedback suggests several improvements, including removing defensive getattr checks for guaranteed attributes, logging swallowed exceptions in callback execution blocks to aid in debugging, and implementing missing standard grpc.Call methods in _DeadlineExceededError to prevent potential AttributeError crashes in downstream code.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Added methods for initial and trailing metadata, time remaining, and active status
Handle exceptions during channel subscription to avoid crashes.
Removed redundant pass statements in exception handling.
Added logic to fire callbacks after handling exceptions.
…Error Add cancel and add_callback methods to interceptor to avoid AttributeError
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 1 of 2 splitting #18019.
This PR adds the standalone
google.auth.transport.mtls_interceptormodule (CertRotationInterceptorandMTLSRefreshingChannel) and its unit tests (tests/transport/test_mtls_interceptor.py) to support automatic gRPC mTLS certificate rotation uponUNAUTHENTICATEDerrors when client certificates rotate.See go/grpc-cert-rotation-in-pythonsdk-for-x509 for details.
Pre-review checklist
go/author-standard).