Skip to content

fix(storage): set GRPC_ALTS_MAX_CONCURRENT_HANDSHAKES=2 in benchmark runner #18638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
shradhakatyal wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −0
Draft

fix(storage): set GRPC_ALTS_MAX_CONCURRENT_HANDSHAKES=2 in benchmark runner #18638

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions packages/google-cloud-storage/cloudbuild/run_benchmark_tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,11 @@ ROUNDS="${ROUNDS:-3}" # Run benchmark 3 rounds by default
BUCKET_TYPE="${BUCKET_TYPE:-rapid}" # "rapid" uses BidiReadObject gRPC DirectPath, "regional" uses REST/gRPC standard
RAPID_BUCKET="${RAPID_BUCKET:-${DEFAULT_RAPID_BUCKET:-gcs-read-bench-zb-us-west4-a}}"
REGIONAL_BUCKET="${REGIONAL_BUCKET:-${DEFAULT_STANDARD_BUCKET:-gcs-read-bench-rb-us-west4}}"
# Limit concurrent ALTS handshakes per worker process to 2 so that 48 worker
# processes never exceed 96 total concurrent streams against the local GCE
# metadata server (169.254.169.254:8080, ~100 stream buffer limit), preventing
# GOAWAY [11] "Buffers full" errors while still handshaking multiple subchannels.
GRPC_ALTS_MAX_CONCURRENT_HANDSHAKES="${GRPC_ALTS_MAX_CONCURRENT_HANDSHAKES:-2}"
if [ -n "${TARGET_BUCKET:-}" ]; then
if [ "${BUCKET_TYPE}" = "regional" ]; then
REGIONAL_BUCKET="${TARGET_BUCKET}"
Expand All @@ -39,6 +44,7 @@ echo " Rounds: ${ROUNDS}"
echo " Bucket Type: ${BUCKET_TYPE}"
echo " Rapid Bucket: gs://${RAPID_BUCKET}"
echo " Regional Bucket: gs://${REGIONAL_BUCKET}"
echo " ALTS Handshakes: ${GRPC_ALTS_MAX_CONCURRENT_HANDSHAKES}"
echo " Output JSON Path: ${OUTPUT_JSON_PATH}"
echo " Upload GCS Path: ${UPLOAD_GCS_PREFIX:-None}"
echo "========================================================================"
Expand All @@ -51,6 +57,7 @@ export FILE_SIZE_MIB="${FILE_SIZE_MIB}"
export CHUNK_SIZE_KIB="${CHUNK_SIZE_KIB}"
export ROUNDS="${ROUNDS}"
export BUCKET_TYPE="${BUCKET_TYPE}"
export GRPC_ALTS_MAX_CONCURRENT_HANDSHAKES="${GRPC_ALTS_MAX_CONCURRENT_HANDSHAKES}"

# Navigate to package directory
SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
Expand Down
Loading