Repository navigation
Conversation
Reuse `shared_database` instead of creating and dropping a dedicated database in `test_session_api.py`. Previously, `sessions_database` provisioned a separate Spanner database with all 20 schema tables and protobuf descriptors, duplicating what `shared_database` already provides in `conftest.py`. Changes: - Refactor the `sessions_database` fixture to wrap and return `shared_database`. - Pre-warm a session in the pool so OpenTelemetry span tests expecting `session_found=True` continue to pass. - Eliminate redundant database creation, DDL execution, and teardown drop calls, saving ~1 minute in standard CI.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the sessions_database fixture in packages/google-cloud-spanner/tests/system/test_session_api.py to utilize the shared_database fixture, removing the redundant database creation and teardown logic. There are no review comments, and we have no feedback to provide.
parthea
added
kokoro:force-run
yoshi-kokoro
removed
kokoro:run
Contributor
|
@olavloite Please could you take a look at the failing system test? |
parthea
marked this pull request as draft
October 13, 2026 15:58
olavloite
marked this pull request as ready for review
October 14, 2026 11:56
Contributor
Author
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reuse
shared_databaseinstead of creating and dropping a dedicated database intest_session_api.py.Previously,
sessions_databaseprovisioned a separate Spanner database with all 20 schema tables and protobuf descriptors, duplicating whatshared_databasealready provides inconftest.py.Changes:
sessions_databasefixture to wrap and returnshared_database.session_found=Truecontinue to pass.