Repository navigation
feat(bigtable): raise the UDS channel inbound message cap to 256 MB #18782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
59 changes: 59 additions & 0 deletions
59
packages/google-cloud-bigtable/tests/unit/data/test_accelerator_client.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| # Copyright 2026 Google LLC | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| """Unit tests for the UDS channel configuration in _accelerator_client.py.""" | ||
|
|
||
| from unittest import mock | ||
|
|
||
| import pytest | ||
|
|
||
| from google.cloud.bigtable.data._async import _accelerator_client as async_module | ||
| from google.cloud.bigtable.data._sync_autogen import ( | ||
| _accelerator_client as sync_module, | ||
| ) | ||
|
|
||
| _MODULES = pytest.mark.parametrize( | ||
| "module, client_name", | ||
| [ | ||
| (async_module, "_AsyncAcceleratorClient"), | ||
| (sync_module, "_AcceleratorClient"), | ||
| ], | ||
| ids=["async", "sync"], | ||
| ) | ||
|
|
||
|
|
||
| class TestChannelOptions: | ||
| """The caps are load-bearing, and the option keys are easy to typo. | ||
|
|
||
| A misspelled key is silently ignored by gRPC, which leaves the channel on | ||
| the 4 MiB default and fails only on a large row. | ||
| """ | ||
|
|
||
| @_MODULES | ||
| def test_options_cap_each_direction_at_the_service_limit(self, module, client_name): | ||
| # Inbound 256 MiB: the hard limit on all values in a single row. | ||
| # Outbound 100 MB: the request size the service accepts. | ||
| assert module._MAX_RECEIVE_MESSAGE_LENGTH == 256 * 1024 * 1024 | ||
| assert module._MAX_SEND_MESSAGE_LENGTH == 100 * 1024 * 1024 | ||
| assert module._CHANNEL_OPTIONS == ( | ||
| ("grpc.max_receive_message_length", 256 * 1024 * 1024), | ||
| ("grpc.max_send_message_length", 100 * 1024 * 1024), | ||
| ) | ||
|
|
||
| @_MODULES | ||
| def test_channel_is_built_with_the_options(self, module, client_name): | ||
| with mock.patch.object(module, "insecure_channel") as channel_mock: | ||
| getattr(module, client_name)("/tmp/sock", "secret") | ||
| channel_mock.assert_called_once_with( | ||
| module._uds_target("/tmp/sock"), options=module._CHANNEL_OPTIONS | ||
| ) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.