feat(pubsub): retry confirmed_nack partial failures in Subscriber#5563
Merged
PhongChuong merged 3 commits intogoogleapis:mainfrom Apr 30, 2026
Merged
feat(pubsub): retry confirmed_nack partial failures in Subscriber#5563PhongChuong merged 3 commits intogoogleapis:mainfrom
PhongChuong merged 3 commits intogoogleapis:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5563 +/- ##
========================================
Coverage 97.78% 97.78%
========================================
Files 219 219
Lines 49764 49895 +131
========================================
+ Hits 48661 48791 +130
- Misses 1103 1104 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dbolduc
approved these changes
Apr 30, 2026
Contributor
Author
|
@dbolduc , thanks for the review. I've also added a check in the retry loop logic. PTAL. |
dbolduc
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #4804