Skip to content

feat(pubsub): retry confirmed_nack partial failures in Subscriber#5563

Merged
PhongChuong merged 3 commits intogoogleapis:mainfrom
PhongChuong:psNackRetry
Apr 30, 2026
Merged

feat(pubsub): retry confirmed_nack partial failures in Subscriber#5563
PhongChuong merged 3 commits intogoogleapis:mainfrom
PhongChuong:psNackRetry

Conversation

@PhongChuong
Copy link
Copy Markdown
Contributor

Towards #4804

@PhongChuong PhongChuong requested a review from a team as a code owner April 29, 2026 20:08
@product-auto-label product-auto-label Bot added the api: pubsub Issues related to the Pub/Sub API. label Apr 29, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 29, 2026

Codecov Report

❌ Patch coverage is 99.27536% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 97.78%. Comparing base (89a9e12) to head (0cc5add).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/pubsub/src/subscriber/leaser.rs 99.25% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             main    #5563    +/-   ##
========================================
  Coverage   97.78%   97.78%            
========================================
  Files         219      219            
  Lines       49764    49895   +131     
========================================
+ Hits        48661    48791   +130     
- Misses       1103     1104     +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread src/pubsub/src/subscriber/leaser.rs
Comment thread src/pubsub/src/subscriber/leaser.rs
@PhongChuong
Copy link
Copy Markdown
Contributor Author

@dbolduc , thanks for the review. I've also added a check in the retry loop logic. PTAL.

@PhongChuong PhongChuong merged commit a7a1562 into googleapis:main Apr 30, 2026
35 checks passed
@PhongChuong PhongChuong deleted the psNackRetry branch April 30, 2026 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: pubsub Issues related to the Pub/Sub API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants