chore: bump & generate#5572
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs necessary dependency version updates for internal Google Cloud Rust libraries. These changes ensure that the project remains up-to-date with the latest library versions, following a previous generation cycle. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the versions of google-cloud-gax-internal to 0.7.13 and google-cloud-identity-accesscontextmanager-type to 1.5.0 across the repository, including workspace manifests, lock files, and generation configurations. A review comment identifies that google-cloud-gax in librarian.yaml also needs to be updated to version 1.10.0 to ensure consistency with the workspace settings and correct code generation.
| output: src/gax | ||
| - name: google-cloud-gax-internal | ||
| version: 0.7.12 | ||
| version: 0.7.13 |
There was a problem hiding this comment.
While bumping google-cloud-gax-internal, please also ensure that the version for google-cloud-gax at line 832 is updated to 1.10.0 to match the workspace Cargo.toml and Cargo.lock. It appears this was missed in the previous bump mentioned in the PR description, and keeping librarian.yaml in sync is necessary for correct code generation.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5572 +/- ##
=======================================
Coverage 97.79% 97.79%
=======================================
Files 219 219
Lines 50217 50217
=======================================
+ Hits 49108 49109 +1
+ Misses 1109 1108 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Run
bumpandgenerateagain after #5504.Looks like
gaxigot a bump that wasn't picked up by the previous bump due to manual nature of that one.