Skip to content

feat(gax): implement grpc client - #415

Merged
nolanleastin merged 7 commits into
googleapis:mainfrom
nolanleastin:neastin/grpc-client
Aug 13, 2026
Merged

feat(gax): implement grpc client#415
nolanleastin merged 7 commits into
googleapis:mainfrom
nolanleastin:neastin/grpc-client

Conversation

@nolanleastin

Copy link
Copy Markdown
Contributor

No description provided.

@nolanleastin
nolanleastin marked this pull request as ready for review August 12, 2026 23:02
@nolanleastin
nolanleastin requested a review from a team as a code owner August 12, 2026 23:02
@coryan coryan changed the title feat(wkt): implement grpc client feat(gax): implement grpc client Aug 12, 2026
@coryan

coryan commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

I changed the title to feat(gax): ...

@coryan coryan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dependency stuff is a blocker for me, the other stuff is minor.

Comment thread packages/gax/Sources/GoogleCloudGax/GRPCClient.swift Outdated
Comment thread packages/gax/Sources/GoogleCloudGaxGRPC/GRPCClient.swift
Comment thread packages/gax/Sources/GoogleCloudGax/GRPCClient.swift Outdated
Comment thread packages/gax/Package.swift Outdated

@coryan coryan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits, please fix and merge

Comment thread packages/gax/Sources/GoogleCloudGax/HeaderNames.swift Outdated
Comment thread packages/gax/Sources/GoogleCloudGaxGRPC/GRPCClient.swift
Comment thread packages/gax/Tests/GRPCClientTests.swift Outdated
@nolanleastin
nolanleastin enabled auto-merge (squash) August 13, 2026 16:50
@nolanleastin
nolanleastin merged commit ca7c10b into googleapis:main Aug 13, 2026
22 checks passed
@nolanleastin
nolanleastin deleted the neastin/grpc-client branch August 13, 2026 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants