feat(gax): implement grpc client - #415
Conversation
coryan
changed the title
|
I changed the title to |
coryan
left a comment
coryan
left a comment
There was a problem hiding this comment.
The dependency stuff is a blocker for me, the other stuff is minor.
| if !routingParams.isEmpty { | ||
| callOptions.customMetadata.add( | ||
| name: "x-goog-request-params", | ||
| value: routingParams.joined(separator: "&") |
There was a problem hiding this comment.
I assume then routingParams has to be percent-encoded already? please document this in the parameters for this function.
There was a problem hiding this comment.
Still applicable, please document the restrictions on routingParams.
coryan
left a comment
coryan
left a comment
There was a problem hiding this comment.
Some nits, please fix and merge
|
|
||
| /// Common Google header names used across HTTP and gRPC transports. | ||
| @_spi(GoogleCloudInternal) | ||
| public enum HeaderNames { |
There was a problem hiding this comment.
Belt and suspenders ...
| public enum HeaderNames { | |
| public enum _HeaderNames { |
Ignore what I said about _apiClient one symbol with underscores is enough.
| if !routingParams.isEmpty { | ||
| callOptions.customMetadata.add( | ||
| name: "x-goog-request-params", | ||
| value: routingParams.joined(separator: "&") |
There was a problem hiding this comment.
Still applicable, please document the restrictions on routingParams.
|
|
||
| import Foundation | ||
| import Testing | ||
| @_spi(GoogleCloudInternal) @testable import GoogleCloudGax |
There was a problem hiding this comment.
Maybe just
| @_spi(GoogleCloudInternal) @testable import GoogleCloudGax | |
| import GoogleCloudGax |
??
2 participants
No description provided.