Repository navigation
docs: restore ProGuard setup instructions - #2171
arnabnandy7 wants to merge 2 commits into
Conversation
|
The restored rules appear incomplete for strict R8 full mode: model construction also requires protection for public no-argument constructors. I reproduced this with Adding the following rule alongside the existing attribute and annotated-field rules fixes the reproducer’s parsing cases, including typed nested models: The existing annotated-field rule should remain: request classes with only parameterized constructors do not match this additional rule, and their JSON field names still need protection. The 2.2.0 construction code calls Could this documentation cover constructor retention too? Bundled consumer rules and an R8 regression test would also help prevent applications from having to discover this requirement independently. |
Signed-off-by: Arnab Nandy <arnab_nandy7@yahoo.com>
Signed-off-by: Arnab Nandy <arnab_nandy7@yahoo.com>
0d20270 to
e924cee
Compare
@ashughes yes why not, I've updated please review. |
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #2089 ☕️
Summary
Restores the missing ProGuard section in the setup documentation using the existing rules from
google-http-client-assembly/proguard-google-http-client.txt.The documentation also separates the Android-specific warning suppression from the common rules, making the instructions applicable to desktop applications.
Validation
git diff --check