Skip to content

feat(core): protocol and wire transport support for secure parameters - #775

Open
anubhav756 wants to merge 1 commit into
mainfrom
anubhav-secure-params
Open

feat(core): protocol and wire transport support for secure parameters#775
anubhav756 wants to merge 1 commit into
mainfrom
anubhav-secure-params

Conversation

@anubhav756

@anubhav756 anubhav756 commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Description

Implements the protocol and wire transport layer for Secure Parameters (com.google.cloud/toolbox.v1) in core package, per MCP SEP-2243.

This change enables MCP client capabilities advertisement, discovery parsing of secureInputSchema, and serialization of secureArguments during tool execution in MCP protocol v2026-07-28.

Changes

  • Advertises extensions["com.google.cloud/toolbox.v1"] = {} during MCP initialization.
  • Extends ToolSchema to parse secureInputSchema into secure_parameters: list[ParameterSchema] during tools/list.
  • Adds secure_arguments (serialization_alias="secureArguments") to CallToolRequestParams.
  • Updates abstract ITransport.tool_invoke() to accept secure_arguments: Optional[Mapping[str, Any]] = None.
  • Enforces NotImplementedError across legacy transports (v20241105, v20250326, v20250618, v20251125) if non-empty secure_arguments is passed.
  • Added unit tests verifying client capability advertisement, secureInputSchema discovery parsing, and wire-level secureArguments JSON payload formatting.
  • Added unit tests in test_v20241105.py, test_v20250326.py, test_v20250618.py, and test_v20251125.py asserting NotImplementedError.

@anubhav756 anubhav756 changed the title feat(core): add support for secure parameters `com.google.cloud/toolb… feat(core): add support for secure parameters com.google.cloud/toolbox.v1 Aug 19, 2026
@anubhav756
anubhav756 force-pushed the anubhav-secure-params branch from 791a5ce to f31f800 Compare August 19, 2026 13:30
@anubhav756
anubhav756 marked this pull request as ready for review August 19, 2026 14:30
@anubhav756
anubhav756 requested a review from a team as a code owner August 19, 2026 14:30
@anubhav756
anubhav756 force-pushed the anubhav-secure-params branch 2 times, most recently from 3a7f0a2 to fb86f81 Compare August 20, 2026 05:55
@anubhav756 anubhav756 changed the title feat(core): add support for secure parameters com.google.cloud/toolbox.v1 feat(core): protocol and wire transport support for secure parameters Aug 20, 2026
@anubhav756
anubhav756 force-pushed the anubhav-secure-params branch from fb86f81 to b5cd3fd Compare August 20, 2026 06:25
@twishabansal

Copy link
Copy Markdown
Contributor

nit: Small description/code mismatch: the description says we advertise {"secure_parameters": True} but the code sends {}.

@anubhav756

Copy link
Copy Markdown
Contributor Author

nit: Small description/code mismatch: the description says we advertise {"secure_parameters": True} but the code sends {}.

Updated. Thanks for catching that!

@anubhav756
anubhav756 force-pushed the anubhav-secure-params branch from b5cd3fd to f635811 Compare August 25, 2026 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants